2021-06-23 21:26:26

by Christophe JAILLET

[permalink] [raw]
Subject: [PATCH] ath11k: Remove some duplicate code

'ATH11K_HE_MCS_MAX' is 11, so these 2 blocks of code are exactly the same.
Remove the one that uses a hard-coded constant.

Signed-off-by: Christophe JAILLET <[email protected]>
---
drivers/net/wireless/ath/ath11k/dp_rx.c | 5 -----
1 file changed, 5 deletions(-)

diff --git a/drivers/net/wireless/ath/ath11k/dp_rx.c b/drivers/net/wireless/ath/ath11k/dp_rx.c
index 603d2f93ac18..9a224817630a 100644
--- a/drivers/net/wireless/ath/ath11k/dp_rx.c
+++ b/drivers/net/wireless/ath/ath11k/dp_rx.c
@@ -1406,11 +1406,6 @@ ath11k_update_per_peer_tx_stats(struct ath11k *ar,
* Firmware rate's control to be skipped for this?
*/

- if (flags == WMI_RATE_PREAMBLE_HE && mcs > 11) {
- ath11k_warn(ab, "Invalid HE mcs %d peer stats", mcs);
- return;
- }
-
if (flags == WMI_RATE_PREAMBLE_HE && mcs > ATH11K_HE_MCS_MAX) {
ath11k_warn(ab, "Invalid HE mcs %d peer stats", mcs);
return;
--
2.30.2


2021-07-02 11:43:11

by Kalle Valo

[permalink] [raw]
Subject: Re: [PATCH] ath11k: Remove some duplicate code

Christophe JAILLET <[email protected]> wrote:

> 'ATH11K_HE_MCS_MAX' is 11, so these 2 blocks of code are exactly the same.
> Remove the one that uses a hard-coded constant.
>
> Signed-off-by: Christophe JAILLET <[email protected]>
> Signed-off-by: Kalle Valo <[email protected]>

Patch applied to ath-next branch of ath.git, thanks.

0791ba2bc7d3 ath11k: Remove some duplicate code

--
https://patchwork.kernel.org/project/linux-wireless/patch/a65952db7f4[email protected]wanadoo.fr/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches