2021-07-06 18:51:45

by Dan Williams

[permalink] [raw]
Subject: Re: [PATCH v2 4/4] bus: Make remove callback return void

On Tue, Jul 6, 2021 at 8:51 AM Uwe Kleine-K├Ânig
<[email protected]> wrote:
>
> The driver core ignores the return value of this callback because there
> is only little it can do when a device disappears.
>
> This is the final bit of a long lasting cleanup quest where several
> buses were converted to also return void from their remove callback.
> Additionally some resource leaks were fixed that were caused by drivers
> returning an error code in the expectation that the driver won't go
> away.
>
> With struct bus_type::remove returning void it's prevented that newly
> implemented buses return an ignored error code and so don't anticipate
> wrong expectations for driver authors.
>

> drivers/cxl/core.c | 3 +--
> drivers/dax/bus.c | 4 +---
> drivers/nvdimm/bus.c | 3 +--

For CXL, DAX, and NVDIMM

Acked-by: Dan Williams <[email protected]>