2021-07-30 17:50:21

by Uwe Kleine-König

[permalink] [raw]
Subject: Re: [PATCH v1 0/5] PCI: Drop duplicated tracking of a pci_dev's bound driver

Hi Andy,

On Fri, Jul 30, 2021 at 11:06:20AM +0300, Andy Shevchenko wrote:
> On Thu, Jul 29, 2021 at 10:37:35PM +0200, Uwe Kleine-K?nig wrote:
> > struct pci_dev tracks the bound pci driver twice. This series is about
> > removing this duplication.
> >
> > The first two patches are just cleanups. The third patch introduces a
> > wrapper that abstracts access to struct pci_dev->driver. In the next
> > patch (hopefully) all users are converted to use the new wrapper and
> > finally the fifth patch removes the duplication.
> >
> > Note this series is only build tested (allmodconfig on several
> > architectures).
> >
> > I'm open to restructure this series if this simplifies things. E.g. the
> > use of the new wrapper in drivers/pci could be squashed into the patch
> > introducing the wrapper. Patch 4 could be split by maintainer tree or
> > squashed into patch 3 completely.
> I see only patch 4 and this cover letter...

The full series is available at

https://lore.kernel.org/linux-pci/[email protected]/

All patches but #4 only touch drivers/pci/ (and include/linux/pci.h) and
it seemed excessive to me to send all patches to all people. It seems at
least for you I balanced this wrongly. The short version is that patch
#3 introduces

+#define pci_driver_of_dev(pdev) ((pdev)->driver)

which allows to do the stuff done in patch #4 and then patch #5 does

-#define pci_driver_of_dev(pdev) ((pdev)->driver)
+#define pci_driver_of_dev(pdev) ((pdev)->dev.driver ? to_pci_driver((pdev)->dev.driver) : NULL)

plus some cleanups.

If you want I can send you a bounce (or you try

b4 am [email protected]


Best regards and thanks for caring,

Pengutronix e.K. | Uwe Kleine-K?nig |
Industrial Linux Solutions | https://www.pengutronix.de/ |

(No filename) (1.91 kB)
signature.asc (499.00 B)
Download all attachments