2021-09-17 08:09:33

by Krzysztof Kozlowski

[permalink] [raw]
Subject: Re: [PATCH] nfc: trf7970a: Make use of the helper function dev_err_probe()

On 16/09/2021 17:36, Cai Huoqing wrote:
> When possible use dev_err_probe help to properly deal with the
> PROBE_DEFER error, the benefit is that DEFER issue will be logged
> in the devices_deferred debugfs file.
> Using dev_err_probe() can reduce code size, and the error value
> gets printed.
> Signed-off-by: Cai Huoqing <[email protected]>
> ---
> drivers/nfc/trf7970a.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)

Please don't send patches one-by-one, but group them in series.

Same response - I think the preferred approach was Rob's dev_err removal.

P.S. You need to Cc all folks and all lists. The cc-list here is too short.

Best regards,