2021-09-21 01:38:37

by Jérôme Pouiller

[permalink] [raw]
Subject: [PATCH v7 03/24] wfx: add Makefile/Kconfig

From: Jérôme Pouiller <[email protected]>

Signed-off-by: Jérôme Pouiller <[email protected]>
---
drivers/net/wireless/silabs/wfx/Kconfig | 12 +++++++++++
drivers/net/wireless/silabs/wfx/Makefile | 26 ++++++++++++++++++++++++
2 files changed, 38 insertions(+)
create mode 100644 drivers/net/wireless/silabs/wfx/Kconfig
create mode 100644 drivers/net/wireless/silabs/wfx/Makefile

diff --git a/drivers/net/wireless/silabs/wfx/Kconfig b/drivers/net/wireless/silabs/wfx/Kconfig
new file mode 100644
index 000000000000..3be4b1e735e1
--- /dev/null
+++ b/drivers/net/wireless/silabs/wfx/Kconfig
@@ -0,0 +1,12 @@
+config WFX
+ tristate "Silicon Labs wireless chips WF200 and further"
+ depends on MAC80211
+ depends on MMC || !MMC # do not allow WFX=y if MMC=m
+ depends on (SPI || MMC)
+ help
+ This is a driver for Silicons Labs WFxxx series (WF200 and further)
+ chipsets. This chip can be found on SPI or SDIO buses.
+
+ Silabs does not use a reliable SDIO vendor ID. So, to avoid conflicts,
+ the driver won't probe the device if it is not also declared in the
+ Device Tree.
diff --git a/drivers/net/wireless/silabs/wfx/Makefile b/drivers/net/wireless/silabs/wfx/Makefile
new file mode 100644
index 000000000000..f399962c8619
--- /dev/null
+++ b/drivers/net/wireless/silabs/wfx/Makefile
@@ -0,0 +1,26 @@
+# SPDX-License-Identifier: GPL-2.0
+
+# Necessary for CREATE_TRACE_POINTS
+CFLAGS_debug.o = -I$(src)
+
+wfx-y := \
+ bh.o \
+ hwio.o \
+ fwio.o \
+ hif_tx_mib.o \
+ hif_tx.o \
+ hif_rx.o \
+ queue.o \
+ data_tx.o \
+ data_rx.o \
+ scan.o \
+ sta.o \
+ key.o \
+ main.o \
+ sta.o \
+ debug.o
+wfx-$(CONFIG_SPI) += bus_spi.o
+# When CONFIG_MMC == m, append to 'wfx-y' (and not to 'wfx-m')
+wfx-$(subst m,y,$(CONFIG_MMC)) += bus_sdio.o
+
+obj-$(CONFIG_WFX) += wfx.o
--
2.33.0


2021-10-01 09:06:50

by Kalle Valo

[permalink] [raw]
Subject: Re: [PATCH v7 03/24] wfx: add Makefile/Kconfig

Jerome Pouiller <[email protected]> writes:

> From: Jérôme Pouiller <[email protected]>
>
> Signed-off-by: Jérôme Pouiller <[email protected]>
> ---
> drivers/net/wireless/silabs/wfx/Kconfig | 12 +++++++++++
> drivers/net/wireless/silabs/wfx/Makefile | 26 ++++++++++++++++++++++++
> 2 files changed, 38 insertions(+)
> create mode 100644 drivers/net/wireless/silabs/wfx/Kconfig
> create mode 100644 drivers/net/wireless/silabs/wfx/Makefile
>
> diff --git a/drivers/net/wireless/silabs/wfx/Kconfig
> b/drivers/net/wireless/silabs/wfx/Kconfig
> new file mode 100644
> index 000000000000..3be4b1e735e1
> --- /dev/null
> +++ b/drivers/net/wireless/silabs/wfx/Kconfig
> @@ -0,0 +1,12 @@
> +config WFX
> + tristate "Silicon Labs wireless chips WF200 and further"

Kconfig file should have an SPDX tag as well.

--
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches

2021-10-01 09:07:50

by Kalle Valo

[permalink] [raw]
Subject: Re: [PATCH v7 03/24] wfx: add Makefile/Kconfig

Jerome Pouiller <[email protected]> writes:

> From: Jérôme Pouiller <[email protected]>
>
> Signed-off-by: Jérôme Pouiller <[email protected]>

[...]

> --- /dev/null
> +++ b/drivers/net/wireless/silabs/wfx/Makefile
> @@ -0,0 +1,26 @@
> +# SPDX-License-Identifier: GPL-2.0

All other files use GPL-2.0-only:

bh.c:// SPDX-License-Identifier: GPL-2.0-only
bh.h:/* SPDX-License-Identifier: GPL-2.0-only */
bus.h:/* SPDX-License-Identifier: GPL-2.0-only */
bus_sdio.c:// SPDX-License-Identifier: GPL-2.0-only
bus_spi.c:// SPDX-License-Identifier: GPL-2.0-only
data_rx.c:// SPDX-License-Identifier: GPL-2.0-only

I don't remember what's the difference, if any, but having consistent
SPDX tags would be nice.

--
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches