2021-10-21 06:08:59

by Kevin Lo

Subject: [PATCH wireless-drivers-next] rtw89: remove duplicate register definitions

Remove duplicate register definitions.

Signed-off-by: Kevin Lo <[email protected]>
---
diff --git a/drivers/net/wireless/realtek/rtw89/pci.h b/drivers/net/wireless/realtek/rtw89/pci.h
index 34333c441aea..20e6767ea5c4 100644
--- a/drivers/net/wireless/realtek/rtw89/pci.h
+++ b/drivers/net/wireless/realtek/rtw89/pci.h
@@ -276,11 +276,6 @@
#define B_AX_CH10_BUSY BIT(0)

/* Configure */
-#define R_AX_PCIE_INIT_CFG1 0x1000
-#define B_AX_PCIE_RXRST_KEEP_REG BIT(23)
-#define B_AX_PCIE_TXRST_KEEP_REG BIT(22)
-#define B_AX_DIS_RXDMA_PRE BIT(2)
-
#define R_AX_PCIE_INIT_CFG2 0x1004
#define B_AX_WD_ITVL_IDLE GENMASK(27, 24)
#define B_AX_WD_ITVL_ACT GENMASK(19, 16)

2021-10-21 06:12:07

by Ping-Ke Shih

Subject: RE: [PATCH wireless-drivers-next] rtw89: remove duplicate register definitions

> -----Original Message-----
> From: Kevin Lo <[email protected]>
> Sent: Thursday, October 21, 2021 1:44 PM
> To: [email protected]
> Cc: Pkshih <[email protected]>
> Subject: [PATCH wireless-drivers-next] rtw89: remove duplicate register definitions
>
> Remove duplicate register definitions.
>
> Signed-off-by: Kevin Lo <[email protected]>

Acked-by: Ping-Ke Shih <[email protected]>

> ---
> diff --git a/drivers/net/wireless/realtek/rtw89/pci.h b/drivers/net/wireless/realtek/rtw89/pci.h
> index 34333c441aea..20e6767ea5c4 100644
> --- a/drivers/net/wireless/realtek/rtw89/pci.h
> +++ b/drivers/net/wireless/realtek/rtw89/pci.h
> @@ -276,11 +276,6 @@
> #define B_AX_CH10_BUSY BIT(0)
>
> /* Configure */
> -#define R_AX_PCIE_INIT_CFG1 0x1000
> -#define B_AX_PCIE_RXRST_KEEP_REG BIT(23)
> -#define B_AX_PCIE_TXRST_KEEP_REG BIT(22)
> -#define B_AX_DIS_RXDMA_PRE BIT(2)
> -
> #define R_AX_PCIE_INIT_CFG2 0x1004
> #define B_AX_WD_ITVL_IDLE GENMASK(27, 24)
> #define B_AX_WD_ITVL_ACT GENMASK(19, 16)
> ------Please consider the environment before printing this e-mail.

2021-10-27 18:53:27

by Kalle Valo

Subject: Re: [PATCH wireless-drivers-next] rtw89: remove duplicate register definitions

Kevin Lo <[email protected]> wrote:

> Remove duplicate register definitions.
>
> Signed-off-by: Kevin Lo <[email protected]>
>
> diff --git a/drivers/net/wireless/realtek/rtw89/pci.h b/drivers/net/wireless/realtek/rtw89/pci.h
> index 34333c441aea..20e6767ea5c4 100644
> --- a/drivers/net/wireless/realtek/rtw89/pci.h
> +++ b/drivers/net/wireless/realtek/rtw89/pci.h
> @@ -276,11 +276,6 @@
> #define B_AX_CH10_BUSY BIT(0)
>
> /* Configure */
> -#define R_AX_PCIE_INIT_CFG1 0x1000
> -#define B_AX_PCIE_RXRST_KEEP_REG BIT(23)
> -#define B_AX_PCIE_TXRST_KEEP_REG BIT(22)
> -#define B_AX_DIS_RXDMA_PRE BIT(2)
> -
> #define R_AX_PCIE_INIT_CFG2 0x1004
> #define B_AX_WD_ITVL_IDLE GENMASK(27, 24)
> #define B_AX_WD_ITVL_ACT GENMASK(19, 16)

Patch applied to wireless-drivers-next.git, thanks.

090f8a2f7b38 rtw89: remove duplicate register definitions

--
https://patchwork.kernel.org/project/linux-wireless/patch/[email protected]/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches