2021-12-12 22:33:57

by Merlijn Wajer

[permalink] [raw]
Subject: [PATCH] wl1251: specify max. IE length

This fix is similar to commit 77c91295ea53 ("wil6210: specify max. IE
length"). Without the max IE length set, wpa_supplicant cannot operate
using the nl80211 interface.

This patch is a workaround - the number 512 is taken from the wlcore
driver, but note that per Paul Fertser:

there's no correct number because the driver will ignore the data
passed in extra IEs.

Suggested-by: Paul Fertser <[email protected]>
Signed-off-by: Merlijn Wajer <[email protected]>
---
drivers/net/wireless/ti/wl1251/main.c | 6 ++++++
1 file changed, 6 insertions(+)

diff --git a/drivers/net/wireless/ti/wl1251/main.c b/drivers/net/wireless/ti/wl1251/main.c
index 136a0d3b23c9..a25a6143e65f 100644
--- a/drivers/net/wireless/ti/wl1251/main.c
+++ b/drivers/net/wireless/ti/wl1251/main.c
@@ -1520,6 +1520,12 @@ int wl1251_init_ieee80211(struct wl1251 *wl)
wl->hw->wiphy->interface_modes = BIT(NL80211_IFTYPE_STATION) |
BIT(NL80211_IFTYPE_ADHOC);
wl->hw->wiphy->max_scan_ssids = 1;
+
+ /* We set max_scan_ie_len to a random value to make wpa_supplicant scans not
+ * fail, as the driver will the ignore the extra passed IEs anyway
+ */
+ wl->hw->wiphy->max_scan_ie_len = 512;
+
wl->hw->wiphy->bands[NL80211_BAND_2GHZ] = &wl1251_band_2ghz;

wl->hw->queues = 4;
--
2.32.0



2021-12-16 08:29:08

by Kalle Valo

[permalink] [raw]
Subject: Re: [PATCH] wl1251: specify max. IE length

Merlijn Wajer <[email protected]> wrote:

> This fix is similar to commit 77c91295ea53 ("wil6210: specify max. IE
> length"). Without the max IE length set, wpa_supplicant cannot operate
> using the nl80211 interface.
>
> This patch is a workaround - the number 512 is taken from the wlcore
> driver, but note that per Paul Fertser:
>
> there's no correct number because the driver will ignore the data
> passed in extra IEs.
>
> Suggested-by: Paul Fertser <[email protected]>
> Signed-off-by: Merlijn Wajer <[email protected]>

Patch applied to wireless-drivers-next.git, thanks.

97affcfa15bb wl1251: specify max. IE length

--
https://patchwork.kernel.org/project/linux-wireless/patch/[email protected]/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches