2022-05-24 16:18:12

by Nathan Chancellor

Subject: [PATCH] ath6kl: Use cc-disable-warning to disable -Wdangling-pointer

Clang does not support this option so the build fails:

error: unknown warning option '-Wno-dangling-pointer' [-Werror,-Wunknown-warning-option]

Use cc-disable-warning so that the option is only added when it is
supported.

Fixes: bd1d129daa3e ("wifi: ath6k: silence false positive -Wno-dangling-pointer warning on GCC 12")
Reported-by: "kernelci.org bot" <[email protected]>
Signed-off-by: Nathan Chancellor <[email protected]>
---
drivers/net/wireless/ath/ath6kl/Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/wireless/ath/ath6kl/Makefile b/drivers/net/wireless/ath/ath6kl/Makefile
index 01cc0d50fee6..a75bfa9fd1cf 100644
--- a/drivers/net/wireless/ath/ath6kl/Makefile
+++ b/drivers/net/wireless/ath/ath6kl/Makefile
@@ -38,7 +38,7 @@ ath6kl_core-y += recovery.o

# FIXME: temporarily silence -Wdangling-pointer on non W=1+ builds
ifndef KBUILD_EXTRA_WARN
-CFLAGS_htc_mbox.o += -Wno-dangling-pointer
+CFLAGS_htc_mbox.o += $(call cc-disable-warning, dangling-pointer)
endif

ath6kl_core-$(CONFIG_NL80211_TESTMODE) += testmode.o

base-commit: 677fb7525331375ba2f90f4bc94a80b9b6e697a3
--
2.36.1

2022-05-25 01:19:00

by patchwork-bot+netdevbpf

Subject: Re: [PATCH] ath6kl: Use cc-disable-warning to disable -Wdangling-pointer

Hello:

This patch was applied to netdev/net-next.git (master)
by Jakub Kicinski <[email protected]>:

On Tue, 24 May 2022 07:56:55 -0700 you wrote:
> Clang does not support this option so the build fails:
>
> error: unknown warning option '-Wno-dangling-pointer' [-Werror,-Wunknown-warning-option]
>
> Use cc-disable-warning so that the option is only added when it is
> supported.
>
> [...]

Here is the summary with links:
- ath6kl: Use cc-disable-warning to disable -Wdangling-pointer
https://git.kernel.org/netdev/net-next/c/48a75b979940

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html