2022-08-01 11:11:05

by Kalle Valo

[permalink] [raw]
Subject: [PATCH wireless] wifi: wilc1000: fix spurious inline in wilc_handle_disconnect()

Sparse warns:

drivers/net/wireless/microchip/wilc1000/hif.h:218:35: error: marked inline, but without a definition

Remove the inline, it's not needed.

Reported-by: Jakub Kicinski <[email protected]>
Signed-off-by: Kalle Valo <[email protected]>
---
drivers/net/wireless/microchip/wilc1000/hif.c | 2 +-
drivers/net/wireless/microchip/wilc1000/hif.h | 3 ++-
2 files changed, 3 insertions(+), 2 deletions(-)

diff --git a/drivers/net/wireless/microchip/wilc1000/hif.c b/drivers/net/wireless/microchip/wilc1000/hif.c
index b89519ab9205..eb1d1ba3a443 100644
--- a/drivers/net/wireless/microchip/wilc1000/hif.c
+++ b/drivers/net/wireless/microchip/wilc1000/hif.c
@@ -635,7 +635,7 @@ static inline void host_int_parse_assoc_resp_info(struct wilc_vif *vif,
conn_info->req_ies_len = 0;
}

-inline void wilc_handle_disconnect(struct wilc_vif *vif)
+void wilc_handle_disconnect(struct wilc_vif *vif)
{
struct host_if_drv *hif_drv = vif->hif_drv;

diff --git a/drivers/net/wireless/microchip/wilc1000/hif.h b/drivers/net/wireless/microchip/wilc1000/hif.h
index 69ba1d469e9f..baa2881f4465 100644
--- a/drivers/net/wireless/microchip/wilc1000/hif.h
+++ b/drivers/net/wireless/microchip/wilc1000/hif.h
@@ -215,5 +215,6 @@ void wilc_gnrl_async_info_received(struct wilc *wilc, u8 *buffer, u32 length);
void *wilc_parse_join_bss_param(struct cfg80211_bss *bss,
struct cfg80211_crypto_settings *crypto);
int wilc_set_default_mgmt_key_index(struct wilc_vif *vif, u8 index);
-inline void wilc_handle_disconnect(struct wilc_vif *vif);
+void wilc_handle_disconnect(struct wilc_vif *vif);
+
#endif

base-commit: 63757225a93353bc2ce4499af5501eabdbbf23f9
--
2.30.2



2022-08-01 14:19:20

by Ajay Singh

[permalink] [raw]
Subject: Re: [PATCH wireless] wifi: wilc1000: fix spurious inline in wilc_handle_disconnect()

On 01/08/22 16:34, Kalle Valo wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
>
> Sparse warns:
>
> drivers/net/wireless/microchip/wilc1000/hif.h:218:35: error: marked inline, but without a definition
>
> Remove the inline, it's not needed.
>
Acked-by: Ajay Singh <[email protected]>


> Reported-by: Jakub Kicinski <[email protected]>
> Signed-off-by: Kalle Valo <[email protected]>
> ---
> drivers/net/wireless/microchip/wilc1000/hif.c | 2 +-
> drivers/net/wireless/microchip/wilc1000/hif.h | 3 ++-
> 2 files changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/wireless/microchip/wilc1000/hif.c b/drivers/net/wireless/microchip/wilc1000/hif.c
> index b89519ab9205..eb1d1ba3a443 100644
> --- a/drivers/net/wireless/microchip/wilc1000/hif.c
> +++ b/drivers/net/wireless/microchip/wilc1000/hif.c
> @@ -635,7 +635,7 @@ static inline void host_int_parse_assoc_resp_info(struct wilc_vif *vif,
> conn_info->req_ies_len = 0;
> }
>
> -inline void wilc_handle_disconnect(struct wilc_vif *vif)
> +void wilc_handle_disconnect(struct wilc_vif *vif)
> {
> struct host_if_drv *hif_drv = vif->hif_drv;
>
> diff --git a/drivers/net/wireless/microchip/wilc1000/hif.h b/drivers/net/wireless/microchip/wilc1000/hif.h
> index 69ba1d469e9f..baa2881f4465 100644
> --- a/drivers/net/wireless/microchip/wilc1000/hif.h
> +++ b/drivers/net/wireless/microchip/wilc1000/hif.h
> @@ -215,5 +215,6 @@ void wilc_gnrl_async_info_received(struct wilc *wilc, u8 *buffer, u32 length);
> void *wilc_parse_join_bss_param(struct cfg80211_bss *bss,
> struct cfg80211_crypto_settings *crypto);
> int wilc_set_default_mgmt_key_index(struct wilc_vif *vif, u8 index);
> -inline void wilc_handle_disconnect(struct wilc_vif *vif);
> +void wilc_handle_disconnect(struct wilc_vif *vif);
> +
> #endif
>
> base-commit: 63757225a93353bc2ce4499af5501eabdbbf23f9
> --
> 2.30.2
>

2022-08-08 08:12:06

by Kalle Valo

[permalink] [raw]
Subject: Re: [PATCH wireless] wifi: wilc1000: fix spurious inline in wilc_handle_disconnect()

Kalle Valo <[email protected]> wrote:

> Sparse warns:
>
> drivers/net/wireless/microchip/wilc1000/hif.h:218:35: error: marked inline, but without a definition
>
> Remove the inline, it's not needed.
>
> Reported-by: Jakub Kicinski <[email protected]>
> Signed-off-by: Kalle Valo <[email protected]>
> Acked-by: Ajay Singh <[email protected]>

Patch applied to wireless.git, thanks.

f01272ee3856 wifi: wilc1000: fix spurious inline in wilc_handle_disconnect()

--
https://patchwork.kernel.org/project/linux-wireless/patch/202[email protected]/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches