2022-11-18 04:36:02

by Ping-Ke Shih

Subject: [PATCH] wifi: rtw89: fix physts IE page check

From: Zong-Zhe Yang <[email protected]>

The index RTW89_PHYSTS_BITMAP_NUM is not a valid physts IE page.
So, fix the check condition.

Fixes: eb4e52b3f38d ("rtw89: fix incorrect channel info during scan")
Signed-off-by: Zong-Zhe Yang <[email protected]>
Signed-off-by: Ping-Ke Shih <[email protected]>
---
drivers/net/wireless/realtek/rtw89/phy.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/wireless/realtek/rtw89/phy.c b/drivers/net/wireless/realtek/rtw89/phy.c
index dd46856989830..944bb0f2ee633 100644
--- a/drivers/net/wireless/realtek/rtw89/phy.c
+++ b/drivers/net/wireless/realtek/rtw89/phy.c
@@ -3340,7 +3340,7 @@ void rtw89_phy_env_monitor_track(struct rtw89_dev *rtwdev)

static bool rtw89_physts_ie_page_valid(enum rtw89_phy_status_bitmap *ie_page)
{
- if (*ie_page > RTW89_PHYSTS_BITMAP_NUM ||
+ if (*ie_page >= RTW89_PHYSTS_BITMAP_NUM ||
*ie_page == RTW89_RSVD_9)
return false;
else if (*ie_page > RTW89_RSVD_9)
--
2.25.1

2022-11-22 10:18:08

by Kalle Valo

Subject: Re: [PATCH] wifi: rtw89: fix physts IE page check

Ping-Ke Shih <[email protected]> wrote:

> From: Zong-Zhe Yang <[email protected]>
>
> The index RTW89_PHYSTS_BITMAP_NUM is not a valid physts IE page.
> So, fix the check condition.
>
> Fixes: eb4e52b3f38d ("rtw89: fix incorrect channel info during scan")
> Signed-off-by: Zong-Zhe Yang <[email protected]>
> Signed-off-by: Ping-Ke Shih <[email protected]>

Patch applied to wireless-next.git, thanks.

9e2f177de1bf wifi: rtw89: fix physts IE page check

--
https://patchwork.kernel.org/project/linux-wireless/patch/[email protected]/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches