2023-02-07 05:24:32

by Jiapeng Chong

Subject: [PATCH] ath10k: Remove redundant assignment to changed_flags

Variable changed_flags is assigned, but is not effectively used, so
delete it.

drivers/net/wireless/ath/ath10k/mac.c:6024:22: warning: parameter 'changed_flags' set but not used.

Reported-by: Abaci Robot <[email protected]>
Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=3963
Signed-off-by: Jiapeng Chong <[email protected]>
---
drivers/net/wireless/ath/ath10k/mac.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/drivers/net/wireless/ath/ath10k/mac.c b/drivers/net/wireless/ath/ath10k/mac.c
index ec8d5b29bc72..7675858f069b 100644
--- a/drivers/net/wireless/ath/ath10k/mac.c
+++ b/drivers/net/wireless/ath/ath10k/mac.c
@@ -6030,7 +6030,6 @@ static void ath10k_configure_filter(struct ieee80211_hw *hw,

mutex_lock(&ar->conf_mutex);

- changed_flags &= SUPPORTED_FILTERS;
*total_flags &= SUPPORTED_FILTERS;
ar->filter_flags = *total_flags;

--
2.20.1.7.g153144c

2023-02-07 17:26:09

by Simon Horman

Subject: Re: [PATCH] ath10k: Remove redundant assignment to changed_flags

On Tue, Feb 07, 2023 at 01:24:10PM +0800, Jiapeng Chong wrote:
> Variable changed_flags is assigned, but is not effectively used, so
> delete it.
>
> drivers/net/wireless/ath/ath10k/mac.c:6024:22: warning: parameter 'changed_flags' set but not used.
>
> Reported-by: Abaci Robot <[email protected]>
> Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=3963
> Signed-off-by: Jiapeng Chong <[email protected]>

Reviewed-by: Simon Horman <[email protected]>

2023-02-22 10:05:06

by Kalle Valo

Subject: Re: [PATCH] ath10k: Remove redundant assignment to changed_flags

Jiapeng Chong <[email protected]> wrote:

> Variable changed_flags is assigned, but is not effectively used, so
> delete it.
>
> drivers/net/wireless/ath/ath10k/mac.c:6024:22: warning: parameter 'changed_flags' set but not used.
>
> Reported-by: Abaci Robot <[email protected]>
> Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=3963
> Signed-off-by: Jiapeng Chong <[email protected]>
> Reviewed-by: Simon Horman <[email protected]>
> Signed-off-by: Kalle Valo <[email protected]>

Patch applied to ath-next branch of ath.git, thanks.

7c4c511f74ba wifi: ath10k: Remove redundant assignment to changed_flags

--
https://patchwork.kernel.org/project/linux-wireless/patch/[email protected]/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches