2023-10-24 00:33:05

by Liam Kearney

Subject: [PATCH] wifi: ieee80211: fix PV1 frame control field name

Update PV1 frame control field TODS to FROMDS to match 802.11 standard

Signed-off-by: Liam Kearney <[email protected]>
---
include/linux/ieee80211.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/include/linux/ieee80211.h b/include/linux/ieee80211.h
index bd2f6e19c357..ca46147e6a2d 100644
--- a/include/linux/ieee80211.h
+++ b/include/linux/ieee80211.h
@@ -176,7 +176,7 @@
#define IEEE80211_PV1_FCTL_VERS 0x0003
#define IEEE80211_PV1_FCTL_FTYPE 0x001c
#define IEEE80211_PV1_FCTL_STYPE 0x00e0
-#define IEEE80211_PV1_FCTL_TODS 0x0100
+#define IEEE80211_PV1_FCTL_FROMDS 0x0100
#define IEEE80211_PV1_FCTL_MOREFRAGS 0x0200
#define IEEE80211_PV1_FCTL_PM 0x0400
#define IEEE80211_PV1_FCTL_MOREDATA 0x0800
--
2.39.2

2023-10-24 14:49:35

by Jeff Johnson

Subject: Re: [PATCH] wifi: ieee80211: fix PV1 frame control field name

On 10/23/2023 5:32 PM, Liam Kearney wrote:
> Update PV1 frame control field TODS to FROMDS to match 802.11 standard
>
> Signed-off-by: Liam Kearney <[email protected]>
> ---
> include/linux/ieee80211.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/linux/ieee80211.h b/include/linux/ieee80211.h
> index bd2f6e19c357..ca46147e6a2d 100644
> --- a/include/linux/ieee80211.h
> +++ b/include/linux/ieee80211.h
> @@ -176,7 +176,7 @@
> #define IEEE80211_PV1_FCTL_VERS 0x0003
> #define IEEE80211_PV1_FCTL_FTYPE 0x001c
> #define IEEE80211_PV1_FCTL_STYPE 0x00e0
> -#define IEEE80211_PV1_FCTL_TODS 0x0100
> +#define IEEE80211_PV1_FCTL_FROMDS 0x0100
> #define IEEE80211_PV1_FCTL_MOREFRAGS 0x0200
> #define IEEE80211_PV1_FCTL_PM 0x0400
> #define IEEE80211_PV1_FCTL_MOREDATA 0x0800

Suggest that along with this change you update the preceding comment to
refer to IEEE 802.11-2020 since that supersedes 802.11ah (the paragraph
number is unchanged between the two)