2022-10-21 05:40:56

by syzbot

[permalink] [raw]
Subject: [syzbot] UBSAN: array-index-out-of-bounds in diWrite

Hello,

syzbot found the following issue on:

HEAD commit: 493ffd6605b2 Merge tag 'ucount-rlimits-cleanups-for-v5.19'..
git tree: upstream
console+strace: https://syzkaller.appspot.com/x/log.txt?x=1512cd9a880000
kernel config: https://syzkaller.appspot.com/x/.config?x=d19f5d16783f901
dashboard link: https://syzkaller.appspot.com/bug?extid=c1056fdfe414463fdb33
compiler: Debian clang version 13.0.1-++20220126092033+75e33f71c2da-1~exp1~20220126212112.63, GNU ld (GNU Binutils for Debian) 2.35.2
syz repro: https://syzkaller.appspot.com/x/repro.syz?x=12f431d2880000
C reproducer: https://syzkaller.appspot.com/x/repro.c?x=1208894a880000

Downloadable assets:
disk image: https://storage.googleapis.com/syzbot-assets/f1ff6481e26f/disk-493ffd66.raw.xz
vmlinux: https://storage.googleapis.com/syzbot-assets/101bd3c7ae47/vmlinux-493ffd66.xz
mounted in repro: https://storage.googleapis.com/syzbot-assets/720c16671db9/mount_0.gz

IMPORTANT: if you fix the issue, please add the following tag to the commit:
Reported-by: [email protected]

================================================================================
UBSAN: array-index-out-of-bounds in fs/jfs/jfs_imap.c:749:4
index 255 is out of range for type 'struct dtslot [128]'
CPU: 1 PID: 3606 Comm: syz-executor322 Not tainted 6.0.0-syzkaller-09423-g493ffd6605b2 #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 10/11/2022
Call Trace:
<TASK>
__dump_stack lib/dump_stack.c:88 [inline]
dump_stack_lvl+0x1b1/0x28e lib/dump_stack.c:106
ubsan_epilogue lib/ubsan.c:151 [inline]
__ubsan_handle_out_of_bounds+0xdb/0x130 lib/ubsan.c:283
diWrite+0x1311/0x1f80 fs/jfs/jfs_imap.c:749
txCommit+0xa2e/0x6d40 fs/jfs/jfs_txnmgr.c:1250
jfs_mkdir+0x911/0xb00 fs/jfs/namei.c:290
vfs_mkdir+0x3b3/0x590 fs/namei.c:4013
do_mkdirat+0x279/0x550 fs/namei.c:4038
__do_sys_mkdirat fs/namei.c:4053 [inline]
__se_sys_mkdirat fs/namei.c:4051 [inline]
__x64_sys_mkdirat+0x85/0x90 fs/namei.c:4051
do_syscall_x64 arch/x86/entry/common.c:50 [inline]
do_syscall_64+0x3d/0xb0 arch/x86/entry/common.c:80
entry_SYSCALL_64_after_hwframe+0x63/0xcd
RIP: 0033:0x7f1a977dfe49
Code: ff ff c3 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 40 00 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 c0 ff ff ff f7 d8 64 89 01 48
RSP: 002b:00007ffd8f230c48 EFLAGS: 00000246 ORIG_RAX: 0000000000000102
RAX: ffffffffffffffda RBX: 0000000000000000 RCX: 00007f1a977dfe49
RDX: 00000000000001ff RSI: 00000000200000c0 RDI: ffffffffffffff9c
RBP: 00007f1a9779f610 R08: 0000000000000000 R09: 0000000000000000
R10: 00005555566302c0 R11: 0000000000000246 R12: 00000000f8008000
R13: 0000000000000000 R14: 00083878000000fc R15: 0000000000000000
</TASK>
================================================================================


---
This report is generated by a bot. It may contain errors.
See https://goo.gl/tpsmEJ for more information about syzbot.
syzbot engineers can be reached at [email protected].

syzbot will keep track of this issue. See:
https://goo.gl/tpsmEJ#status for how to communicate with syzbot.
syzbot can test patches for this issue, for details see:
https://goo.gl/tpsmEJ#testing-patches


2023-11-02 15:03:14

by syzbot

[permalink] [raw]
Subject: Re: [syzbot] test

For archival purposes, forwarding an incoming command email to
[email protected].

***

Subject: test
Author: [email protected]

#syz test:
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master

2023-11-03 03:12:45

by syzbot

[permalink] [raw]
Subject: Re: [syzbot] test

For archival purposes, forwarding an incoming command email to
[email protected].

***

Subject: test
Author: [email protected]

#syz test:
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master

2023-11-03 07:19:05

by syzbot

[permalink] [raw]
Subject: Re: [syzbot] test

For archival purposes, forwarding an incoming command email to
[email protected].

***

Subject: test
Author: [email protected]

#syz test:
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master

2023-11-03 07:29:55

by syzbot

[permalink] [raw]
Subject: Re: [syzbot] test

For archival purposes, forwarding an incoming command email to
[email protected].

***

Subject: test
Author: [email protected]

#syz test:
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master

2024-01-14 07:18:26

by syzbot

[permalink] [raw]
Subject: Re: [syzbot] [jfs?] UBSAN: array-index-out-of-bounds in diWrite

syzbot suspects this issue was fixed by commit:

commit 6f861765464f43a71462d52026fbddfc858239a5
Author: Jan Kara <[email protected]>
Date: Wed Nov 1 17:43:10 2023 +0000

fs: Block writes to mounted block devices

bisection log: https://syzkaller.appspot.com/x/bisect.txt?x=17ec162be80000
start commit: 493ffd6605b2 Merge tag 'ucount-rlimits-cleanups-for-v5.19'..
git tree: upstream
kernel config: https://syzkaller.appspot.com/x/.config?x=d19f5d16783f901
dashboard link: https://syzkaller.appspot.com/bug?extid=c1056fdfe414463fdb33
syz repro: https://syzkaller.appspot.com/x/repro.syz?x=12f431d2880000
C reproducer: https://syzkaller.appspot.com/x/repro.c?x=1208894a880000

If the result looks correct, please mark the issue as fixed by replying with:

#syz fix: fs: Block writes to mounted block devices

For information about bisection process see: https://goo.gl/tpsmEJ#bisection

2024-01-15 13:42:42

by Jan Kara

[permalink] [raw]
Subject: Re: [syzbot] [jfs?] UBSAN: array-index-out-of-bounds in diWrite

On Sat 13-01-24 23:18:05, syzbot wrote:
> syzbot suspects this issue was fixed by commit:
>
> commit 6f861765464f43a71462d52026fbddfc858239a5
> Author: Jan Kara <[email protected]>
> Date: Wed Nov 1 17:43:10 2023 +0000
>
> fs: Block writes to mounted block devices
>
> bisection log: https://syzkaller.appspot.com/x/bisect.txt?x=17ec162be80000
> start commit: 493ffd6605b2 Merge tag 'ucount-rlimits-cleanups-for-v5.19'..
> git tree: upstream
> kernel config: https://syzkaller.appspot.com/x/.config?x=d19f5d16783f901
> dashboard link: https://syzkaller.appspot.com/bug?extid=c1056fdfe414463fdb33
> syz repro: https://syzkaller.appspot.com/x/repro.syz?x=12f431d2880000
> C reproducer: https://syzkaller.appspot.com/x/repro.c?x=1208894a880000
>
> If the result looks correct, please mark the issue as fixed by replying with:

Makes sense:

#syz fix: fs: Block writes to mounted block devices

Honza
--
Jan Kara <[email protected]>
SUSE Labs, CR

2024-01-15 14:12:31

by Christian Brauner

[permalink] [raw]
Subject: Re: [syzbot] [jfs?] UBSAN: array-index-out-of-bounds in diWrite

On Mon, Jan 15, 2024 at 02:42:28PM +0100, Jan Kara wrote:
> On Sat 13-01-24 23:18:05, syzbot wrote:
> > syzbot suspects this issue was fixed by commit:
> >
> > commit 6f861765464f43a71462d52026fbddfc858239a5
> > Author: Jan Kara <[email protected]>
> > Date: Wed Nov 1 17:43:10 2023 +0000
> >
> > fs: Block writes to mounted block devices
> >
> > bisection log: https://syzkaller.appspot.com/x/bisect.txt?x=17ec162be80000
> > start commit: 493ffd6605b2 Merge tag 'ucount-rlimits-cleanups-for-v5.19'..
> > git tree: upstream
> > kernel config: https://syzkaller.appspot.com/x/.config?x=d19f5d16783f901
> > dashboard link: https://syzkaller.appspot.com/bug?extid=c1056fdfe414463fdb33
> > syz repro: https://syzkaller.appspot.com/x/repro.syz?x=12f431d2880000
> > C reproducer: https://syzkaller.appspot.com/x/repro.c?x=1208894a880000
> >
> > If the result looks correct, please mark the issue as fixed by replying with:
>
> Makes sense:
>
> #syz fix: fs: Block writes to mounted block devices

I love how many things this closes. This is awesome!