2024-06-03 10:45:11

by Hillf Danton

[permalink] [raw]
Subject: Re: [syzbot] [ext4?] INFO: task hung in vfs_rmdir (2)

On Sun, 02 Jun 2024 20:50:18 -0700
> syzbot found the following issue on:
>
> HEAD commit: 4a4be1ad3a6e Revert "vfs: Delete the associated dentry whe..
> git tree: upstream
> C reproducer: https://syzkaller.appspot.com/x/repro.c?x=103820f2980000

#syz test https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master

--- x/fs/namei.c
+++ y/fs/namei.c
@@ -4198,6 +4198,8 @@ int vfs_rmdir(struct mnt_idmap *idmap, s

if (!dir->i_op->rmdir)
return -EPERM;
+ if (dir == dentry->d_inode)
+ return -EDEADLK;

dget(dentry);
inode_lock(dentry->d_inode);
--


2024-06-03 11:18:13

by syzbot

[permalink] [raw]
Subject: Re: [syzbot] [ext4?] INFO: task hung in vfs_rmdir (2)

Hello,

syzbot has tested the proposed patch and the reproducer did not trigger any issue:

Reported-and-tested-by: [email protected]

Tested on:

commit: c3f38fa6 Linux 6.10-rc2
git tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
console output: https://syzkaller.appspot.com/x/log.txt?x=12385cba980000
kernel config: https://syzkaller.appspot.com/x/.config?x=eb72437243175f22
dashboard link: https://syzkaller.appspot.com/bug?extid=42986aeeddfd7ed93c8b
compiler: Debian clang version 15.0.6, GNU ld (GNU Binutils for Debian) 2.40
patch: https://syzkaller.appspot.com/x/patch.diff?x=16784f14980000

Note: testing is done by a robot and is best-effort only.