2013-03-19 02:03:03

by Jingoo Han

Subject: [PATCH 1/2] extcon: max8997: use dev_err() instead of pr_err()

dev_err() is more preferred than pr_err().

Signed-off-by: Jingoo Han <[email protected]>
---
drivers/extcon/extcon-max8997.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/extcon/extcon-max8997.c b/drivers/extcon/extcon-max8997.c
index 69641bc..20772ad 100644
--- a/drivers/extcon/extcon-max8997.c
+++ b/drivers/extcon/extcon-max8997.c
@@ -646,7 +646,7 @@ static void max8997_muic_detect_cable_wq(struct work_struct *work)

ret = max8997_muic_detect_dev(info);
if (ret < 0)
- pr_err("failed to detect cable type\n");
+ dev_err(info->dev, "failed to detect cable type\n");
}

static int max8997_muic_probe(struct platform_device *pdev)
--
1.7.2.5

2013-03-19 02:03:43

by Jingoo Han

Subject: [PATCH 2/2] extcon: max8997: add missing const

Fixed the checkpatch warning as below:

WARNING: static const char * array should probably be static const char * const
#163: FILE: drivers/extcon/extcon-max8997.c:163:
+static const char *max8997_extcon_cable[] = {

Signed-off-by: Jingoo Han <[email protected]>
---
drivers/extcon/extcon-max8997.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/extcon/extcon-max8997.c b/drivers/extcon/extcon-max8997.c
index 20772ad..6e8724f 100644
--- a/drivers/extcon/extcon-max8997.c
+++ b/drivers/extcon/extcon-max8997.c
@@ -160,7 +160,7 @@ enum {
_EXTCON_CABLE_NUM,
};

-static const char *max8997_extcon_cable[] = {
+static const char const *max8997_extcon_cable[] = {
[EXTCON_CABLE_USB] = "USB",
[EXTCON_CABLE_USB_HOST] = "USB-Host",
[EXTCON_CABLE_TA] = "TA",
--
1.7.2.5

2013-03-19 03:33:28

by Sachin Kamat

Subject: Re: [PATCH 2/2] extcon: max8997: add missing const

On 19 March 2013 07:33, Jingoo Han <[email protected]> wrote:
> Fixed the checkpatch warning as below:
>
> WARNING: static const char * array should probably be static const char * const
> #163: FILE: drivers/extcon/extcon-max8997.c:163:
> +static const char *max8997_extcon_cable[] = {
>
> Signed-off-by: Jingoo Han <[email protected]>
> ---
> drivers/extcon/extcon-max8997.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/extcon/extcon-max8997.c b/drivers/extcon/extcon-max8997.c
> index 20772ad..6e8724f 100644
> --- a/drivers/extcon/extcon-max8997.c
> +++ b/drivers/extcon/extcon-max8997.c
> @@ -160,7 +160,7 @@ enum {
> _EXTCON_CABLE_NUM,
> };
>
> -static const char *max8997_extcon_cable[] = {
> +static const char const *max8997_extcon_cable[] = {

Shouldn't this be "static const char * const max8997_extcon_cable[]"
as suggested by checkpatch (as mentioned in your commit log)?


--
With warm regards,
Sachin

2013-03-19 03:37:34

by Jingoo Han

Subject: Re: [PATCH 2/2] extcon: max8997: add missing const

> -----Original Message-----
> From: Sachin Kamat [mailto:[email protected]]
> Sent: Tuesday, March 19, 2013 12:33 PM
> To: Jingoo Han
> Cc: MyungJoo Ham; Chanwoo Choi; [email protected]
> Subject: Re: [PATCH 2/2] extcon: max8997: add missing const
>
> On 19 March 2013 07:33, Jingoo Han <[email protected]> wrote:
> > Fixed the checkpatch warning as below:
> >
> > WARNING: static const char * array should probably be static const char * const
> > #163: FILE: drivers/extcon/extcon-max8997.c:163:
> > +static const char *max8997_extcon_cable[] = {
> >
> > Signed-off-by: Jingoo Han <[email protected]>
> > ---
> > drivers/extcon/extcon-max8997.c | 2 +-
> > 1 files changed, 1 insertions(+), 1 deletions(-)
> >
> > diff --git a/drivers/extcon/extcon-max8997.c b/drivers/extcon/extcon-max8997.c
> > index 20772ad..6e8724f 100644
> > --- a/drivers/extcon/extcon-max8997.c
> > +++ b/drivers/extcon/extcon-max8997.c
> > @@ -160,7 +160,7 @@ enum {
> > _EXTCON_CABLE_NUM,
> > };
> >
> > -static const char *max8997_extcon_cable[] = {
> > +static const char const *max8997_extcon_cable[] = {
>
> Shouldn't this be "static const char * const max8997_extcon_cable[]"
> as suggested by checkpatch (as mentioned in your commit log)?

Hi Sachin Kamat,

Although the checkpatch warning is already fixed, I will send v2 patch
for clarity.

Thank you for your comment.

Best regards,
Jingoo Han

>
>
> --
> With warm regards,
> Sachin