2014-02-13 07:14:40

by Weijie Yang

Subject: [PATCH] staging: android: lowmemorykiller: set TIF_MEMDIE before send kill sig

Set TIF_MEMDIE tsk_thread flag before send kill signal to the
selected thread. This is to fit a usual code sequence and avoid
potential race issue.

Signed-off-by: Weijie Yang <[email protected]>
---
drivers/staging/android/lowmemorykiller.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
mode change 100644 => 100755 drivers/staging/android/lowmemorykiller.c

diff --git a/drivers/staging/android/lowmemorykiller.c b/drivers/staging/android/lowmemorykiller.c
old mode 100644
new mode 100755
index 6f094b3..4bcf00a
--- a/drivers/staging/android/lowmemorykiller.c
+++ b/drivers/staging/android/lowmemorykiller.c
@@ -159,8 +159,8 @@ static unsigned long lowmem_scan(struct shrinker *s, struct shrink_control *sc)
selected->pid, selected->comm,
selected_oom_score_adj, selected_tasksize);
lowmem_deathpending_timeout = jiffies + HZ;
- send_sig(SIGKILL, selected, 0);
set_tsk_thread_flag(selected, TIF_MEMDIE);
+ send_sig(SIGKILL, selected, 0);
rem += selected_tasksize;
}

--
1.7.10.4

2014-02-13 08:01:00

by David Rientjes

Subject: Re: [PATCH] staging: android: lowmemorykiller: set TIF_MEMDIE before send kill sig

On Thu, 13 Feb 2014, Weijie Yang wrote:

> Set TIF_MEMDIE tsk_thread flag before send kill signal to the
> selected thread. This is to fit a usual code sequence and avoid
> potential race issue.
>

Ok!

> Signed-off-by: Weijie Yang <[email protected]>
> ---
> drivers/staging/android/lowmemorykiller.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
> mode change 100644 => 100755 drivers/staging/android/lowmemorykiller.c
>

That's bad, we'll want to keep this file with permissions of 0644.

2014-02-14 03:26:13

by Weijie Yang

Subject: Re: [PATCH] staging: android: lowmemorykiller: set TIF_MEMDIE before send kill sig

On Thu, Feb 13, 2014 at 4:00 PM, David Rientjes <[email protected]> wrote:
> On Thu, 13 Feb 2014, Weijie Yang wrote:
>
>> Set TIF_MEMDIE tsk_thread flag before send kill signal to the
>> selected thread. This is to fit a usual code sequence and avoid
>> potential race issue.
>>
>
> Ok!
>
>> Signed-off-by: Weijie Yang <[email protected]>
>> ---
>> drivers/staging/android/lowmemorykiller.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>> mode change 100644 => 100755 drivers/staging/android/lowmemorykiller.c
>>
>
> That's bad, we'll want to keep this file with permissions of 0644.

I will remove this annoying mode change, and resend this patch.

Thanks!