2014-02-14 06:05:05

by Weijie Yang

Subject: [PATCH RESEND] staging: android: lowmemorykiller: set TIF_MEMDIE before send kill sig

Set TIF_MEMDIE tsk_thread flag before send kill signal to the
selected thread. This is to fit a usual code sequence and avoid
potential race issue.

Signed-off-by: Weijie Yang <[email protected]>
---
drivers/staging/android/lowmemorykiller.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/android/lowmemorykiller.c b/drivers/staging/android/lowmemorykiller.c
index 6f094b3..4bcf00a
--- a/drivers/staging/android/lowmemorykiller.c
+++ b/drivers/staging/android/lowmemorykiller.c
@@ -159,8 +159,8 @@ static unsigned long lowmem_scan(struct shrinker *s, struct shrink_control *sc)
selected->pid, selected->comm,
selected_oom_score_adj, selected_tasksize);
lowmem_deathpending_timeout = jiffies + HZ;
- send_sig(SIGKILL, selected, 0);
set_tsk_thread_flag(selected, TIF_MEMDIE);
+ send_sig(SIGKILL, selected, 0);
rem += selected_tasksize;
}

--
1.7.10.4

2014-02-14 10:26:44

by David Rientjes

Subject: Re: [PATCH RESEND] staging: android: lowmemorykiller: set TIF_MEMDIE before send kill sig

On Fri, 14 Feb 2014, Weijie Yang wrote:

> Set TIF_MEMDIE tsk_thread flag before send kill signal to the
> selected thread. This is to fit a usual code sequence and avoid
> potential race issue.
>
> Signed-off-by: Weijie Yang <[email protected]>

Acked-by: David Rientjes <[email protected]>