2014-10-25 19:36:40

by Weijie Yang

Subject: [PATCH 1/2] zram: make max_used_pages reset work correctly

The commit 461a8eee6a ("zram: report maximum used memory") introduces a new
knob "mem_used_max" in zram.stats sysfs, and wants to reset it via write 0
to the sysfs interface.

However, the current code cann't reset it correctly, so let's fix it.

Signed-off-by: Weijie Yang <[email protected]>
---
drivers/block/zram/zram_drv.c | 4 +---
1 files changed, 1 insertions(+), 3 deletions(-)

diff --git a/drivers/block/zram/zram_drv.c b/drivers/block/zram/zram_drv.c
index 0e63e8a..64dd79a 100644
--- a/drivers/block/zram/zram_drv.c
+++ b/drivers/block/zram/zram_drv.c
@@ -173,7 +173,6 @@ static ssize_t mem_used_max_store(struct device *dev,
int err;
unsigned long val;
struct zram *zram = dev_to_zram(dev);
- struct zram_meta *meta = zram->meta;

err = kstrtoul(buf, 10, &val);
if (err || val != 0)
@@ -181,8 +180,7 @@ static ssize_t mem_used_max_store(struct device *dev,

down_read(&zram->init_lock);
if (init_done(zram))
- atomic_long_set(&zram->stats.max_used_pages,
- zs_get_total_pages(meta->mem_pool));
+ atomic_long_set(&zram->stats.max_used_pages, 0);
up_read(&zram->init_lock);

return len;
--
1.7.0.4

2014-10-26 01:41:54

by Minchan Kim

Subject: Re: [PATCH 1/2] zram: make max_used_pages reset work correctly

Hello,

On Sat, Oct 25, 2014 at 05:25:11PM +0800, Weijie Yang wrote:
> The commit 461a8eee6a ("zram: report maximum used memory") introduces a new
> knob "mem_used_max" in zram.stats sysfs, and wants to reset it via write 0
> to the sysfs interface.
>
> However, the current code cann't reset it correctly, so let's fix it.

We wanted to reset it to current used total memory, not 0.

--
Kind regards,
Minchan Kim

2014-10-27 01:23:48

by Weijie Yang

Subject: Re: [PATCH 1/2] zram: make max_used_pages reset work correctly

On Sun, Oct 26, 2014 at 9:41 AM, Minchan Kim <[email protected]> wrote:
> Hello,
>
> On Sat, Oct 25, 2014 at 05:25:11PM +0800, Weijie Yang wrote:
>> The commit 461a8eee6a ("zram: report maximum used memory") introduces a new
>> knob "mem_used_max" in zram.stats sysfs, and wants to reset it via write 0
>> to the sysfs interface.
>>
>> However, the current code cann't reset it correctly, so let's fix it.
>
> We wanted to reset it to current used total memory, not 0.

I misread taht, I will resend the 2/2 patch

> --
> Kind regards,
> Minchan Kim