This patch adds DT bindings for Samsung ufs hci
Reviewed-by: Rob Herring <[email protected]>
Signed-off-by: Alim Akhtar <[email protected]>
---
.../bindings/ufs/samsung,exynos-ufs.yaml | 89 +++++++++++++++++++
1 file changed, 89 insertions(+)
create mode 100644 Documentation/devicetree/bindings/ufs/samsung,exynos-ufs.yaml
diff --git a/Documentation/devicetree/bindings/ufs/samsung,exynos-ufs.yaml b/Documentation/devicetree/bindings/ufs/samsung,exynos-ufs.yaml
new file mode 100644
index 000000000000..38193975c9f1
--- /dev/null
+++ b/Documentation/devicetree/bindings/ufs/samsung,exynos-ufs.yaml
@@ -0,0 +1,89 @@
+# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/ufs/samsung,exynos-ufs.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Samsung SoC series UFS host controller Device Tree Bindings
+
+maintainers:
+ - Alim Akhtar <[email protected]>
+
+description: |
+ Each Samsung UFS host controller instance should have its own node.
+ This binding define Samsung specific binding other then what is used
+ in the common ufshcd bindings
+ [1] Documentation/devicetree/bindings/ufs/ufshcd-pltfrm.txt
+
+properties:
+
+ compatible:
+ enum:
+ - samsung,exynos7-ufs
+
+ reg:
+ items:
+ - description: HCI register
+ - description: vendor specific register
+ - description: unipro register
+ - description: UFS protector register
+
+ reg-names:
+ items:
+ - const: hci
+ - const: vs_hci
+ - const: unipro
+ - const: ufsp
+
+ clocks:
+ items:
+ - description: ufs link core clock
+ - description: unipro main clock
+
+ clock-names:
+ items:
+ - const: core_clk
+ - const: sclk_unipro_main
+
+ interrupts:
+ maxItems: 1
+
+ phys:
+ maxItems: 1
+
+ phy-names:
+ const: ufs-phy
+
+required:
+ - compatible
+ - reg
+ - interrupts
+ - phys
+ - phy-names
+ - clocks
+ - clock-names
+
+additionalProperties: false
+
+examples:
+ - |
+ #include <dt-bindings/interrupt-controller/arm-gic.h>
+ #include <dt-bindings/clock/exynos7-clk.h>
+
+ ufs: ufs@15570000 {
+ compatible = "samsung,exynos7-ufs";
+ reg = <0x15570000 0x100>,
+ <0x15570100 0x100>,
+ <0x15571000 0x200>,
+ <0x15572000 0x300>;
+ reg-names = "hci", "vs_hci", "unipro", "ufsp";
+ interrupts = <GIC_SPI 200 IRQ_TYPE_LEVEL_HIGH>;
+ clocks = <&clock_fsys1 ACLK_UFS20_LINK>,
+ <&clock_fsys1 SCLK_UFSUNIPRO20_USER>;
+ clock-names = "core_clk", "sclk_unipro_main";
+ pinctrl-names = "default";
+ pinctrl-0 = <&ufs_rst_n &ufs_refclk_out>;
+ phys = <&ufs_phy>;
+ phy-names = "ufs-phy";
+ };
+...
--
2.17.1
Hi Rob
Anything else needs to be done for this patch?
On Sat, Jun 13, 2020 at 8:36 AM Alim Akhtar <[email protected]> wrote:
>
> This patch adds DT bindings for Samsung ufs hci
>
> Reviewed-by: Rob Herring <[email protected]>
> Signed-off-by: Alim Akhtar <[email protected]>
> ---
> .../bindings/ufs/samsung,exynos-ufs.yaml | 89 +++++++++++++++++++
> 1 file changed, 89 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/ufs/samsung,exynos-ufs.yaml
>
> diff --git a/Documentation/devicetree/bindings/ufs/samsung,exynos-ufs.yaml b/Documentation/devicetree/bindings/ufs/samsung,exynos-ufs.yaml
> new file mode 100644
> index 000000000000..38193975c9f1
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/ufs/samsung,exynos-ufs.yaml
> @@ -0,0 +1,89 @@
> +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/ufs/samsung,exynos-ufs.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Samsung SoC series UFS host controller Device Tree Bindings
> +
> +maintainers:
> + - Alim Akhtar <[email protected]>
> +
> +description: |
> + Each Samsung UFS host controller instance should have its own node.
> + This binding define Samsung specific binding other then what is used
> + in the common ufshcd bindings
> + [1] Documentation/devicetree/bindings/ufs/ufshcd-pltfrm.txt
> +
> +properties:
> +
> + compatible:
> + enum:
> + - samsung,exynos7-ufs
> +
> + reg:
> + items:
> + - description: HCI register
> + - description: vendor specific register
> + - description: unipro register
> + - description: UFS protector register
> +
> + reg-names:
> + items:
> + - const: hci
> + - const: vs_hci
> + - const: unipro
> + - const: ufsp
> +
> + clocks:
> + items:
> + - description: ufs link core clock
> + - description: unipro main clock
> +
> + clock-names:
> + items:
> + - const: core_clk
> + - const: sclk_unipro_main
> +
> + interrupts:
> + maxItems: 1
> +
> + phys:
> + maxItems: 1
> +
> + phy-names:
> + const: ufs-phy
> +
> +required:
> + - compatible
> + - reg
> + - interrupts
> + - phys
> + - phy-names
> + - clocks
> + - clock-names
> +
> +additionalProperties: false
> +
> +examples:
> + - |
> + #include <dt-bindings/interrupt-controller/arm-gic.h>
> + #include <dt-bindings/clock/exynos7-clk.h>
> +
> + ufs: ufs@15570000 {
> + compatible = "samsung,exynos7-ufs";
> + reg = <0x15570000 0x100>,
> + <0x15570100 0x100>,
> + <0x15571000 0x200>,
> + <0x15572000 0x300>;
> + reg-names = "hci", "vs_hci", "unipro", "ufsp";
> + interrupts = <GIC_SPI 200 IRQ_TYPE_LEVEL_HIGH>;
> + clocks = <&clock_fsys1 ACLK_UFS20_LINK>,
> + <&clock_fsys1 SCLK_UFSUNIPRO20_USER>;
> + clock-names = "core_clk", "sclk_unipro_main";
> + pinctrl-names = "default";
> + pinctrl-0 = <&ufs_rst_n &ufs_refclk_out>;
> + phys = <&ufs_phy>;
> + phy-names = "ufs-phy";
> + };
> +...
> --
> 2.17.1
>
--
Regards,
Alim
On Tue, 13 Jul 2021 at 14:36, Alim Akhtar <[email protected]> wrote:
>
> Hi Rob
> Anything else needs to be done for this patch?
>
> On Sat, Jun 13, 2020 at 8:36 AM Alim Akhtar <[email protected]> wrote:
> >
> > This patch adds DT bindings for Samsung ufs hci
> >
> > Reviewed-by: Rob Herring <[email protected]>
> > Signed-off-by: Alim Akhtar <[email protected]>
It has Rob's ack, so it can be taken directly via SCSI tree.
Chanho,
I guess here is the answer why exynos7-ufs compatible was not
documented, so you can build on top of it.
Best regards,
Krzysztof
> > Hi Rob
> > Anything else needs to be done for this patch?
> >
> > On Sat, Jun 13, 2020 at 8:36 AM Alim Akhtar <[email protected]>
> wrote:
> > >
> > > This patch adds DT bindings for Samsung ufs hci
> > >
> > > Reviewed-by: Rob Herring <[email protected]>
> > > Signed-off-by: Alim Akhtar <[email protected]>
>
> It has Rob's ack, so it can be taken directly via SCSI tree.
>
> Chanho,
> I guess here is the answer why exynos7-ufs compatible was not documented,
> so you can build on top of it.
>
Great. I'll update my compatibles on top of this patch.
Anyway, who will take this patch?
Best Regards,
Chanho Park
Chanho,
>> It has Rob's ack, so it can be taken directly via SCSI tree.
> Anyway, who will take this patch?
I can't remember the rationale behind only taking a subset of the exynos
series through SCSI. However, it's been over a year. A resend is a
prerequisite.
--
Martin K. Petersen Oracle Linux Engineering
> >> It has Rob's ack, so it can be taken directly via SCSI tree.
>
> > Anyway, who will take this patch?
>
> I can't remember the rationale behind only taking a subset of the exynos
> series through SCSI. However, it's been over a year. A resend is a
> prerequisite.
Okay.
Alim, please resend the patch without Rob's review tag.
> The binding should have been applied with the driver. If you want me
> to apply, resend it without my Reviewed-by tag.
Best Regards,
Chanho Park