2022-10-31 09:36:47

by Pierre Gondois

Subject: [PATCH 20/20] arm64: dts: Update cache properties for tesla

The DeviceTree Specification v0.3 specifies that the cache node
'compatible' and 'cache-level' properties are 'required'. Cf.
s3.8 Multi-level and Shared Cache Nodes

The recently added init_of_cache_level() function checks
these properties. Add them if missing.

Signed-off-by: Pierre Gondois <[email protected]>
---
arch/arm64/boot/dts/tesla/fsd.dtsi | 1 +
1 file changed, 1 insertion(+)

diff --git a/arch/arm64/boot/dts/tesla/fsd.dtsi b/arch/arm64/boot/dts/tesla/fsd.dtsi
index f35bc5a288c2..bfab040fc1e4 100644
--- a/arch/arm64/boot/dts/tesla/fsd.dtsi
+++ b/arch/arm64/boot/dts/tesla/fsd.dtsi
@@ -284,6 +284,7 @@ cpucl_l2: l2-cache0 {
cache-size = <0x400000>;
cache-line-size = <64>;
cache-sets = <4096>;
+ cache-level = <2>;
};

idle-states {
--
2.25.1

2022-11-02 21:18:36

by Krzysztof Kozlowski

Subject: Re: (subset) [PATCH 20/20] arm64: dts: Update cache properties for tesla

On Mon, 31 Oct 2022 10:21:19 +0100, Pierre Gondois wrote:
> The DeviceTree Specification v0.3 specifies that the cache node
> 'compatible' and 'cache-level' properties are 'required'. Cf.
> s3.8 Multi-level and Shared Cache Nodes
>
> The recently added init_of_cache_level() function checks
> these properties. Add them if missing.
>
> [...]

Applied, thanks!

[20/20] arm64: dts: Update cache properties for tesla
https://git.kernel.org/krzk/linux/c/3f0d4a02c7490f1aa15764ed85dcf0881bf66b9e

Best regards,
--
Krzysztof Kozlowski <[email protected]>

2022-11-03 05:50:08

by Alim Akhtar

Subject: RE: [PATCH 20/20] arm64: dts: Update cache properties for tesla

>-----Original Message-----
>From: Pierre Gondois [mailto:[email protected]]
>Sent: Monday, October 31, 2022 2:51 PM
>To: [email protected]
>Cc: [email protected]; [email protected]; Rob Herring
><[email protected]>; Krzysztof Kozlowski
><[email protected]>; Alim Akhtar
><[email protected]>; Aswani Reddy <[email protected]>;
>Shashank Prashar <[email protected]>; Sriranjani P
><[email protected]>; [email protected]
>Subject: [PATCH 20/20] arm64: dts: Update cache properties for tesla
>
>The DeviceTree Specification v0.3 specifies that the cache node
'compatible'
>and 'cache-level' properties are 'required'. Cf.
>s3.8 Multi-level and Shared Cache Nodes
>
>The recently added init_of_cache_level() function checks these properties.
>Add them if missing.
>
>Signed-off-by: Pierre Gondois <[email protected]>
>---
Reviewed-by: Alim Akhtar <[email protected]>


> arch/arm64/boot/dts/tesla/fsd.dtsi | 1 +
> 1 file changed, 1 insertion(+)
>
>diff --git a/arch/arm64/boot/dts/tesla/fsd.dtsi
>b/arch/arm64/boot/dts/tesla/fsd.dtsi
>index f35bc5a288c2..bfab040fc1e4 100644
>--- a/arch/arm64/boot/dts/tesla/fsd.dtsi
>+++ b/arch/arm64/boot/dts/tesla/fsd.dtsi
>@@ -284,6 +284,7 @@ cpucl_l2: l2-cache0 {
> cache-size = <0x400000>;
> cache-line-size = <64>;
> cache-sets = <4096>;
>+ cache-level = <2>;
> };
>
> idle-states {
>--
>2.25.1

2022-11-07 18:59:14

by Krzysztof Kozlowski

Subject: Re: (subset) [PATCH 20/20] arm64: dts: Update cache properties for tesla

On 02/11/2022 21:21, Krzysztof Kozlowski wrote:
> On Mon, 31 Oct 2022 10:21:19 +0100, Pierre Gondois wrote:
>> The DeviceTree Specification v0.3 specifies that the cache node
>> 'compatible' and 'cache-level' properties are 'required'. Cf.
>> s3.8 Multi-level and Shared Cache Nodes
>>
>> The recently added init_of_cache_level() function checks
>> these properties. Add them if missing.
>>
>> [...]
>
> Applied, thanks!
>
> [20/20] arm64: dts: Update cache properties for tesla
> https://git.kernel.org/krzk/linux/c/3f0d4a02c7490f1aa15764ed85dcf0881bf66b9e

Now dropped. I understand this is the intention/request of v2.

Best regards,
Krzysztof