2022-10-13 11:41:45

by Padmanabhan Rajanbabu

Subject: [PATCH v3 3/4] arm64: dts: fix UART drive strength values as per FSD HW UM

Drive strength values used for UART is not reflecting the default values
recommended by FSD HW UM.

Fix the drive strength values for UART, thereby ensuring that the existing
device tree file is using default drive strength values recommended by UM
for FSD SoC.

Fixes: 684dac402f21 ("arm64: dts: fsd: Add initial pinctrl support")
Signed-off-by: Padmanabhan Rajanbabu <[email protected]>
---
arch/arm64/boot/dts/tesla/fsd-pinctrl.dtsi | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/arm64/boot/dts/tesla/fsd-pinctrl.dtsi b/arch/arm64/boot/dts/tesla/fsd-pinctrl.dtsi
index 09a492b1fd6e..a2634e70925a 100644
--- a/arch/arm64/boot/dts/tesla/fsd-pinctrl.dtsi
+++ b/arch/arm64/boot/dts/tesla/fsd-pinctrl.dtsi
@@ -309,14 +309,14 @@
samsung,pins = "gpb7-0", "gpb7-1";
samsung,pin-function = <FSD_PIN_FUNC_2>;
samsung,pin-pud = <FSD_PIN_PULL_NONE>;
- samsung,pin-drv = <FSD_PIN_DRV_LV1>;
+ samsung,pin-drv = <FSD_PIN_DRV_LV4>;
};

uart1_data: uart1-data-pins {
samsung,pins = "gpb7-4", "gpb7-5";
samsung,pin-function = <FSD_PIN_FUNC_2>;
samsung,pin-pud = <FSD_PIN_PULL_NONE>;
- samsung,pin-drv = <FSD_PIN_DRV_LV1>;
+ samsung,pin-drv = <FSD_PIN_DRV_LV4>;
};

spi0_bus: spi0-bus-pins {
--
2.17.1

2022-10-14 01:45:37

by Alim Akhtar

Subject: RE: [PATCH v3 3/4] arm64: dts: fix UART drive strength values as per FSD HW UM

>-----Original Message-----
>From: Padmanabhan Rajanbabu [mailto:[email protected]]
>Sent: Thursday, October 13, 2022 4:10 PM
>To: [email protected]; [email protected];
>[email protected]; [email protected];
>[email protected]; [email protected]
>Cc: [email protected]; [email protected]; linux-
>[email protected]; Padmanabhan Rajanbabu
><[email protected]>
>Subject: [PATCH v3 3/4] arm64: dts: fix UART drive strength values as per FSD
>HW UM
>
>Drive strength values used for UART is not reflecting the default values
>recommended by FSD HW UM.
>
>Fix the drive strength values for UART, thereby ensuring that the existing
>device tree file is using default drive strength values recommended by UM for
>FSD SoC.
>
>Fixes: 684dac402f21 ("arm64: dts: fsd: Add initial pinctrl support")
>Signed-off-by: Padmanabhan Rajanbabu <[email protected]>
>---

Reviewed-by: Alim Akhtar <[email protected]>

> arch/arm64/boot/dts/tesla/fsd-pinctrl.dtsi | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
>diff --git a/arch/arm64/boot/dts/tesla/fsd-pinctrl.dtsi
>b/arch/arm64/boot/dts/tesla/fsd-pinctrl.dtsi
>index 09a492b1fd6e..a2634e70925a 100644
>--- a/arch/arm64/boot/dts/tesla/fsd-pinctrl.dtsi
>+++ b/arch/arm64/boot/dts/tesla/fsd-pinctrl.dtsi
>@@ -309,14 +309,14 @@
> samsung,pins = "gpb7-0", "gpb7-1";
> samsung,pin-function = <FSD_PIN_FUNC_2>;
> samsung,pin-pud = <FSD_PIN_PULL_NONE>;
>- samsung,pin-drv = <FSD_PIN_DRV_LV1>;
>+ samsung,pin-drv = <FSD_PIN_DRV_LV4>;
> };
>
> uart1_data: uart1-data-pins {
> samsung,pins = "gpb7-4", "gpb7-5";
> samsung,pin-function = <FSD_PIN_FUNC_2>;
> samsung,pin-pud = <FSD_PIN_PULL_NONE>;
>- samsung,pin-drv = <FSD_PIN_DRV_LV1>;
>+ samsung,pin-drv = <FSD_PIN_DRV_LV4>;
> };
>
> spi0_bus: spi0-bus-pins {
>--
>2.17.1