2014-06-18 05:30:25

by Jingoo Han

Subject: [PATCH] extcon: Remove unnecessary OOM messages

The site-specific OOM messages are unnecessary, because they
duplicate the MM subsystem generic OOM message. The following
checkpatch warning is also removed.

WARNING: Possible unnecessary 'out of memory' message

Signed-off-by: Jingoo Han <[email protected]>
---
drivers/extcon/extcon-arizona.c | 4 +---
drivers/extcon/extcon-max14577.c | 5 ++---
drivers/extcon/extcon-max77693.c | 5 ++---
drivers/extcon/extcon-max8997.c | 4 +---
4 files changed, 6 insertions(+), 12 deletions(-)

diff --git a/drivers/extcon/extcon-arizona.c b/drivers/extcon/extcon-arizona.c
index 6c84e3d..90223a3 100644
--- a/drivers/extcon/extcon-arizona.c
+++ b/drivers/extcon/extcon-arizona.c
@@ -1103,10 +1103,8 @@ static int arizona_extcon_probe(struct platform_device *pdev)
return -EPROBE_DEFER;

info = devm_kzalloc(&pdev->dev, sizeof(*info), GFP_KERNEL);
- if (!info) {
- dev_err(&pdev->dev, "Failed to allocate memory\n");
+ if (!info)
return -ENOMEM;
- }

info->micvdd = devm_regulator_get(arizona->dev, "MICVDD");
if (IS_ERR(info->micvdd)) {
diff --git a/drivers/extcon/extcon-max14577.c b/drivers/extcon/extcon-max14577.c
index d49e891..7309743 100644
--- a/drivers/extcon/extcon-max14577.c
+++ b/drivers/extcon/extcon-max14577.c
@@ -692,10 +692,9 @@ static int max14577_muic_probe(struct platform_device *pdev)
u8 id;

info = devm_kzalloc(&pdev->dev, sizeof(*info), GFP_KERNEL);
- if (!info) {
- dev_err(&pdev->dev, "failed to allocate memory\n");
+ if (!info)
return -ENOMEM;
- }
+
info->dev = &pdev->dev;
info->max14577 = max14577;

diff --git a/drivers/extcon/extcon-max77693.c b/drivers/extcon/extcon-max77693.c
index 2c7c3e1..47998a2 100644
--- a/drivers/extcon/extcon-max77693.c
+++ b/drivers/extcon/extcon-max77693.c
@@ -1099,10 +1099,9 @@ static int max77693_muic_probe(struct platform_device *pdev)

info = devm_kzalloc(&pdev->dev, sizeof(struct max77693_muic_info),
GFP_KERNEL);
- if (!info) {
- dev_err(&pdev->dev, "failed to allocate memory\n");
+ if (!info)
return -ENOMEM;
- }
+
info->dev = &pdev->dev;
info->max77693 = max77693;
if (info->max77693->regmap_muic) {
diff --git a/drivers/extcon/extcon-max8997.c b/drivers/extcon/extcon-max8997.c
index d9f7f1b..045e230 100644
--- a/drivers/extcon/extcon-max8997.c
+++ b/drivers/extcon/extcon-max8997.c
@@ -661,10 +661,8 @@ static int max8997_muic_probe(struct platform_device *pdev)

info = devm_kzalloc(&pdev->dev, sizeof(struct max8997_muic_info),
GFP_KERNEL);
- if (!info) {
- dev_err(&pdev->dev, "failed to allocate memory\n");
+ if (!info)
return -ENOMEM;
- }

info->dev = &pdev->dev;
info->muic = max8997->muic;
--
1.7.10.4

2014-06-18 09:06:45

by Charles Keepax

Subject: Re: [PATCH] extcon: Remove unnecessary OOM messages

On Wed, Jun 18, 2014 at 02:30:21PM +0900, Jingoo Han wrote:
> The site-specific OOM messages are unnecessary, because they
> duplicate the MM subsystem generic OOM message. The following
> checkpatch warning is also removed.
>
> WARNING: Possible unnecessary 'out of memory' message
>
> Signed-off-by: Jingoo Han <[email protected]>
> ---

For the Arizona bit:

Acked-by: Charles Keepax <[email protected]>

Thanks,
Charles

2014-06-20 01:13:25

by Chanwoo Choi

Subject: Re: [PATCH] extcon: Remove unnecessary OOM messages

On 06/18/2014 02:30 PM, Jingoo Han wrote:
> The site-specific OOM messages are unnecessary, because they
> duplicate the MM subsystem generic OOM message. The following
> checkpatch warning is also removed.
>
> WARNING: Possible unnecessary 'out of memory' message
>
> Signed-off-by: Jingoo Han <[email protected]>
> ---
> drivers/extcon/extcon-arizona.c | 4 +---
> drivers/extcon/extcon-max14577.c | 5 ++---
> drivers/extcon/extcon-max77693.c | 5 ++---
> drivers/extcon/extcon-max8997.c | 4 +---
> 4 files changed, 6 insertions(+), 12 deletions(-)

Applied it.

Thanks,
Chanwoo Choi