2013-08-02 05:50:19

by Jingoo Han

Subject: [PATCH] mfd: menelaus: use NULL instead of 0

'mmc_callback_data' and 'vtg' are pointers.
Fix the following sparse warning:

drivers/mfd/menelaus.c:445:43: warning: Using plain integer as NULL pointer
drivers/mfd/menelaus.c:469:20: warning: Using plain integer as NULL pointer

Signed-off-by: Jingoo Han <[email protected]>
---
drivers/mfd/menelaus.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/mfd/menelaus.c b/drivers/mfd/menelaus.c
index 998ce8c..0f62ecd 100644
--- a/drivers/mfd/menelaus.c
+++ b/drivers/mfd/menelaus.c
@@ -442,7 +442,7 @@ void menelaus_unregister_mmc_callback(void)
menelaus_remove_irq_work(MENELAUS_MMC_S2D1_IRQ);

the_menelaus->mmc_callback = NULL;
- the_menelaus->mmc_callback_data = 0;
+ the_menelaus->mmc_callback_data = NULL;
}
EXPORT_SYMBOL(menelaus_unregister_mmc_callback);

@@ -466,7 +466,7 @@ static int menelaus_set_voltage(const struct menelaus_vtg *vtg, int mV,
struct i2c_client *c = the_menelaus->client;

mutex_lock(&the_menelaus->lock);
- if (vtg == 0)
+ if (vtg == NULL)
goto set_voltage;

ret = menelaus_read_reg(vtg->vtg_reg);
--
1.7.10.4

2013-08-02 05:53:23

by Sachin Kamat

Subject: Re: [PATCH] mfd: menelaus: use NULL instead of 0

On 2 August 2013 11:20, Jingoo Han <[email protected]> wrote:
> 'mmc_callback_data' and 'vtg' are pointers.
> Fix the following sparse warning:
>
> drivers/mfd/menelaus.c:445:43: warning: Using plain integer as NULL pointer
> drivers/mfd/menelaus.c:469:20: warning: Using plain integer as NULL pointer
>
> Signed-off-by: Jingoo Han <[email protected]>
> ---
> drivers/mfd/menelaus.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/mfd/menelaus.c b/drivers/mfd/menelaus.c
> index 998ce8c..0f62ecd 100644
> --- a/drivers/mfd/menelaus.c
> +++ b/drivers/mfd/menelaus.c
> @@ -442,7 +442,7 @@ void menelaus_unregister_mmc_callback(void)
> menelaus_remove_irq_work(MENELAUS_MMC_S2D1_IRQ);
>
> the_menelaus->mmc_callback = NULL;
> - the_menelaus->mmc_callback_data = 0;
> + the_menelaus->mmc_callback_data = NULL;
> }
> EXPORT_SYMBOL(menelaus_unregister_mmc_callback);
>
> @@ -466,7 +466,7 @@ static int menelaus_set_voltage(const struct menelaus_vtg *vtg, int mV,
> struct i2c_client *c = the_menelaus->client;
>
> mutex_lock(&the_menelaus->lock);
> - if (vtg == 0)
> + if (vtg == NULL)

Instead you could just make this:
if (!vtg)
> goto set_voltage;
>


--
With warm regards,
Sachin

2013-08-02 05:57:17

by Jingoo Han

Subject: Re: [PATCH] mfd: menelaus: use NULL instead of 0

On Friday, August 02, 2013 2:53 PM, Sachin Kamat wrote:
> On 2 August 2013 11:20, Jingoo Han <[email protected]> wrote:

[...]

> >
> > mutex_lock(&the_menelaus->lock);
> > - if (vtg == 0)
> > + if (vtg == NULL)
>
> Instead you could just make this:
> if (!vtg)

Thank you for your comment. :)
It looks simpler. So, I will use it as you guide.

Best regards,
Jingoo Han