2013-04-11 02:37:42

by Jonghwan Choi

Subject: [PATCH] KVM: ARM: Fix wrong address in comment

hyp_hvc vector offset should be 0x14 and hyp_svc vector offset should be
0x8.

Signed-off-by: Jonghwan Choi <[email protected]>
---
arch/arm/kvm/interrupts.S | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/arm/kvm/interrupts.S b/arch/arm/kvm/interrupts.S
index 8ca87ab..a8e0c2d 100644
--- a/arch/arm/kvm/interrupts.S
+++ b/arch/arm/kvm/interrupts.S
@@ -235,9 +235,9 @@ ENTRY(kvm_call_hyp)
* instruction is issued since all traps are disabled when running the host
* kernel as per the Hyp-mode initialization at boot time.
*
- * HVC instructions cause a trap to the vector page + offset 0x18 (see
hyp_hvc
+ * HVC instructions cause a trap to the vector page + offset 0x14 (see
hyp_hvc
* below) when the HVC instruction is called from SVC mode (i.e. a guest or
the
- * host kernel) and they cause a trap to the vector page + offset 0xc when
HVC
+ * host kernel) and they cause a trap to the vector page + offset 0x8 when
HVC
* instructions are called from within Hyp-mode.
*
* Hyp-ABI: Calling HYP-mode functions from host (in SVC mode):
--
1.7.9.5

2013-04-15 04:37:49

by Christoffer Dall

Subject: Re: [PATCH] KVM: ARM: Fix wrong address in comment

On Wed, Apr 10, 2013 at 7:37 PM, Jonghwan Choi <[email protected]> wrote:
> hyp_hvc vector offset should be 0x14 and hyp_svc vector offset should be
> 0x8.
>
> Signed-off-by: Jonghwan Choi <[email protected]>
> ---
> arch/arm/kvm/interrupts.S | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/kvm/interrupts.S b/arch/arm/kvm/interrupts.S
> index 8ca87ab..a8e0c2d 100644
> --- a/arch/arm/kvm/interrupts.S
> +++ b/arch/arm/kvm/interrupts.S
> @@ -235,9 +235,9 @@ ENTRY(kvm_call_hyp)
> * instruction is issued since all traps are disabled when running the host
> * kernel as per the Hyp-mode initialization at boot time.
> *
> - * HVC instructions cause a trap to the vector page + offset 0x18 (see
> hyp_hvc
> + * HVC instructions cause a trap to the vector page + offset 0x14 (see
> hyp_hvc
> * below) when the HVC instruction is called from SVC mode (i.e. a guest or
> the
> - * host kernel) and they cause a trap to the vector page + offset 0xc when
> HVC
> + * host kernel) and they cause a trap to the vector page + offset 0x8 when
> HVC
> * instructions are called from within Hyp-mode.
> *
> * Hyp-ABI: Calling HYP-mode functions from host (in SVC mode):
> --
> 1.7.9.5
>
this has already been applied:
https://github.com/columbia/linux-kvm-arm/commit/0b5e3bac30c545720f7e6b026241b5f8dd832df2