2015-08-27 14:14:45

by Steve Wise

[permalink] [raw]
Subject: RE: [PATCH] infiniband:cxgb4:Fix incorrect return statement in the function c4iw_reject_cr


> -----Original Message-----
> From: Nicholas Krause [mailto:[email protected]]
> Sent: Wednesday, August 26, 2015 7:22 PM
> To: [email protected]
> Cc: [email protected]; [email protected]; [email protected]; [email protected]; [email protected]
> Subject: [PATCH] infiniband:cxgb4:Fix incorrect return statement in the function c4iw_reject_cr
>
> This fixes the incorrect return statement in the function
> c4iw_reject_cr that returns the value zero directly to instead
> return the variable err as this function can fail when called
> and if so we will incorrectly return success rather then the
> correct status of a failed call to the caller of this particular
> function.
>
> Signed-off-by: Nicholas Krause <[email protected]>
> ---

NAK.

The return code for these cpl handlers indicates if process_work() or other callers needs to free the skb. They are supposed to
return 0.