2003-08-08 20:18:43

by Adrian Bunk

Subject: [2.6 patch] fix net/sk98lin/skge.c for !PROC_FS

I got the following compile error compiling 2.6.0-test2-mm5 with
!CONFIG_PROC_FS:

<-- snip -->

...
CC drivers/net/sk98lin/skge.o
...
drivers/net/sk98lin/skge.c:730: error: `proc_net' undeclared (first use
in this function)
drivers/net/sk98lin/skge.c:730: error: (Each undeclared identifier is
reported only once
drivers/net/sk98lin/skge.c:730: error: for each function it appears in.)
make[3]: *** [drivers/net/sk98lin/skge.o] Error 1

<-- snip -->

The following patch fixes it:

--- linux-2.6.0-test2-mm5/drivers/net/sk98lin/skge.c.old 2003-08-08 20:24:50.000000000 +0200
+++ linux-2.6.0-test2-mm5/drivers/net/sk98lin/skge.c 2003-08-08 20:25:22.000000000 +0200
@@ -724,6 +724,7 @@
SK_MEMCPY(&SK_Root_Dir_entry, BootString,
sizeof(SK_Root_Dir_entry) - 1);

+#ifdef CONFIG_PROC_FS
/*Create proc (directory)*/
if(!proc_root_initialized) {
pSkRootDir = create_proc_entry(SK_Root_Dir_entry,
@@ -731,6 +732,7 @@
pSkRootDir->owner = THIS_MODULE;
proc_root_initialized = 1;
}
+#endif /* CONFIG_PROC_FS */

}



Please apply
Adrian

--

"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed

2003-08-11 06:51:06

by SysKonnect Support

Subject: RE: [2.6 patch] fix net/sk98lin/skge.c for !PROC_FS

Hello Adrian,

Thank you very much for your interest in SysKonnect products.

We will consider your suggestion during the next release.

Thank you again for your cooperation.

Best regards
Karim

SysKonnect GmbH
A Marvell?Company
-------------------------------------
Karim Jamal
Technical Support Engineer
--------------------------------------
Phone: +49 (0) 7243502-330
Fax: +49 (0) 7243502-364
Mail: [email protected]
Web: http:\\http://www.syskonnect.de




-----Original Message-----
From: Adrian Bunk [mailto:[email protected]]
Sent: Friday, August 08, 2003 10:18 PM
To: [email protected]
Cc: [email protected]; [email protected];
[email protected]
Subject: [2.6 patch] fix net/sk98lin/skge.c for !PROC_FS


I got the following compile error compiling 2.6.0-test2-mm5 with
!CONFIG_PROC_FS:

<-- snip -->

...
CC drivers/net/sk98lin/skge.o
...
drivers/net/sk98lin/skge.c:730: error: `proc_net' undeclared (first use
in this function)
drivers/net/sk98lin/skge.c:730: error: (Each undeclared identifier is
reported only once
drivers/net/sk98lin/skge.c:730: error: for each function it appears in.)
make[3]: *** [drivers/net/sk98lin/skge.o] Error 1

<-- snip -->

The following patch fixes it:

--- linux-2.6.0-test2-mm5/drivers/net/sk98lin/skge.c.old 2003-08-08
20:24:50.000000000 +0200
+++ linux-2.6.0-test2-mm5/drivers/net/sk98lin/skge.c 2003-08-08
20:25:22.000000000 +0200
@@ -724,6 +724,7 @@
SK_MEMCPY(&SK_Root_Dir_entry, BootString,
sizeof(SK_Root_Dir_entry) - 1);

+#ifdef CONFIG_PROC_FS
/*Create proc (directory)*/
if(!proc_root_initialized) {
pSkRootDir = create_proc_entry(SK_Root_Dir_entry,
@@ -731,6 +732,7 @@
pSkRootDir->owner = THIS_MODULE;
proc_root_initialized = 1;
}
+#endif /* CONFIG_PROC_FS */

}



Please apply
Adrian

--

"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed