2019-12-04 09:22:11

by Rakesh Pillai

Subject: [PATCH] arm64: dts: qcom: sc7180: Make MSA memory fixed for wifi

The MSA memory is at a fixed offset, which will be
a part of reserved memory. Add this flag to indicate
that wifi in sc7180 will use a fixed memory for MSA.

Signed-off-by: Rakesh Pillai <[email protected]>
---
This patchet is dependent on the below changes
arm64: dts: qcom: sc7180: Add WCN3990 WLAN module device node (https://lore.kernel.org/patchwork/patch/1162434/)
dt: bindings: add dt entry flag to skip SCM call for msa region (https://patchwork.ozlabs.org/patch/1192725/)
---
arch/arm64/boot/dts/qcom/sc7180-idp.dts | 1 +
1 file changed, 1 insertion(+)

diff --git a/arch/arm64/boot/dts/qcom/sc7180-idp.dts b/arch/arm64/boot/dts/qcom/sc7180-idp.dts
index 8a6a760..b2ca143f 100644
--- a/arch/arm64/boot/dts/qcom/sc7180-idp.dts
+++ b/arch/arm64/boot/dts/qcom/sc7180-idp.dts
@@ -250,6 +250,7 @@

&wifi {
status = "okay";
+ qcom,msa_fixed_perm;
};

/* PINCTRL - additions to nodes defined in sc7180.dtsi */
--
2.7.4

2019-12-05 00:58:13

by Matthias Kaehlcke

Subject: Re: [PATCH] arm64: dts: qcom: sc7180: Make MSA memory fixed for wifi

On Wed, Dec 04, 2019 at 09:20:18AM +0000, Rakesh Pillai wrote:

> arm64: dts: qcom: sc7180: Make MSA memory fixed for wifi

This is not really done for sc7180, but only for the sc7180-idp,
which should be reflected in the subject (i.e. s/sc7180/sc7180-idp/)

> The MSA memory is at a fixed offset, which will be
> a part of reserved memory. Add this flag to indicate
> that wifi in sc7180 will use a fixed memory for MSA.

ditto, say it's the IDP

> Signed-off-by: Rakesh Pillai <[email protected]>
> ---
> This patchet is dependent on the below changes
> arm64: dts: qcom: sc7180: Add WCN3990 WLAN module device node (https://lore.kernel.org/patchwork/patch/1162434/)
> dt: bindings: add dt entry flag to skip SCM call for msa region (https://patchwork.ozlabs.org/patch/1192725/)
> ---
> arch/arm64/boot/dts/qcom/sc7180-idp.dts | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/sc7180-idp.dts b/arch/arm64/boot/dts/qcom/sc7180-idp.dts
> index 8a6a760..b2ca143f 100644
> --- a/arch/arm64/boot/dts/qcom/sc7180-idp.dts
> +++ b/arch/arm64/boot/dts/qcom/sc7180-idp.dts
> @@ -250,6 +250,7 @@
>
> &wifi {
> status = "okay";
> + qcom,msa_fixed_perm;
> };
>
> /* PINCTRL - additions to nodes defined in sc7180.dtsi */
> --
> 2.7.4
>

2019-12-11 07:55:23

by Bjorn Andersson

Subject: Re: [PATCH] arm64: dts: qcom: sc7180: Make MSA memory fixed for wifi

On Wed 04 Dec 01:20 PST 2019, Rakesh Pillai wrote:

> The MSA memory is at a fixed offset, which will be
> a part of reserved memory. Add this flag to indicate
> that wifi in sc7180 will use a fixed memory for MSA.
>
> Signed-off-by: Rakesh Pillai <[email protected]>
> ---
> This patchet is dependent on the below changes
> arm64: dts: qcom: sc7180: Add WCN3990 WLAN module device node (https://lore.kernel.org/patchwork/patch/1162434/)

As mentioned for that patch, squash this change into that patch please.

Regards,
Bjorn

> dt: bindings: add dt entry flag to skip SCM call for msa region (https://patchwork.ozlabs.org/patch/1192725/)
> ---
> arch/arm64/boot/dts/qcom/sc7180-idp.dts | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/sc7180-idp.dts b/arch/arm64/boot/dts/qcom/sc7180-idp.dts
> index 8a6a760..b2ca143f 100644
> --- a/arch/arm64/boot/dts/qcom/sc7180-idp.dts
> +++ b/arch/arm64/boot/dts/qcom/sc7180-idp.dts
> @@ -250,6 +250,7 @@
>
> &wifi {
> status = "okay";
> + qcom,msa_fixed_perm;
> };
>
> /* PINCTRL - additions to nodes defined in sc7180.dtsi */
> --
> 2.7.4
>

2019-12-19 07:48:43

by Rakesh Pillai

Subject: RE: [PATCH] arm64: dts: qcom: sc7180: Make MSA memory fixed for wifi

Sure Bjorn.
I have sent v2 for the patch "arm64: dts: qcom: sc7180: Add WCN3990 WLAN
module device node", where I have squashed this change as well.

Thanks,
Rakesh.

> -----Original Message-----
> From: Bjorn Andersson <[email protected]>
> Sent: Wednesday, December 11, 2019 1:23 PM
> To: Rakesh Pillai <[email protected]>
> Cc: [email protected]; [email protected];
linux-
> [email protected]; [email protected]
> Subject: Re: [PATCH] arm64: dts: qcom: sc7180: Make MSA memory fixed for
> wifi
>
> On Wed 04 Dec 01:20 PST 2019, Rakesh Pillai wrote:
>
> > The MSA memory is at a fixed offset, which will be
> > a part of reserved memory. Add this flag to indicate
> > that wifi in sc7180 will use a fixed memory for MSA.
> >
> > Signed-off-by: Rakesh Pillai <[email protected]>
> > ---
> > This patchet is dependent on the below changes
> > arm64: dts: qcom: sc7180: Add WCN3990 WLAN module device node
> (https://lore.kernel.org/patchwork/patch/1162434/)
>
> As mentioned for that patch, squash this change into that patch please.
>
> Regards,
> Bjorn
>
> > dt: bindings: add dt entry flag to skip SCM call for msa region
> (https://patchwork.ozlabs.org/patch/1192725/)
> > ---
> > arch/arm64/boot/dts/qcom/sc7180-idp.dts | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/arch/arm64/boot/dts/qcom/sc7180-idp.dts
> b/arch/arm64/boot/dts/qcom/sc7180-idp.dts
> > index 8a6a760..b2ca143f 100644
> > --- a/arch/arm64/boot/dts/qcom/sc7180-idp.dts
> > +++ b/arch/arm64/boot/dts/qcom/sc7180-idp.dts
> > @@ -250,6 +250,7 @@
> >
> > &wifi {
> > status = "okay";
> > + qcom,msa_fixed_perm;
> > };
> >
> > /* PINCTRL - additions to nodes defined in sc7180.dtsi */
> > --
> > 2.7.4
> >