Hi Chris,
After merging the mmc tree, today's linux-next build (x86_64 allmodconfig)
failed like this:
drivers/net/wireless/rsi/rsi_91x_sdio.c: In function 'rsi_reset_card':
drivers/net/wireless/rsi/rsi_91x_sdio.c:288:20: error: 'MMC_STATE_HIGHSPEED' undeclared (first use in this function)
card->state &= ~MMC_STATE_HIGHSPEED;
^
drivers/net/wireless/rsi/rsi_91x_sdio.c:288:20: note: each undeclared identifier is reported only once for each function it appears in
drivers/net/wireless/rsi/rsi_91x_sdio.c:299:4: error: implicit declaration of function 'mmc_card_set_highspeed' [-Werror=implicit-function-declaration]
mmc_card_set_highspeed(card);
^
drivers/net/wireless/rsi/rsi_91x_sdio.c:306:2: error: implicit declaration of function 'mmc_card_highspeed' [-Werror=implicit-function-declaration]
if (mmc_card_highspeed(card))
^
Caused by commit 395784826a81 ("mmc: drop the speed mode of card's state").
I have used the version of the mmc tree from next-20140417 for today.
--
Cheers,
Stephen Rothwell [email protected]
On Tue, April 22, 2014, Stephen Rothwell wrote:
> Hi Chris,
>
> After merging the mmc tree, today's linux-next build (x86_64 allmodconfig)
> failed like this:
>
> drivers/net/wireless/rsi/rsi_91x_sdio.c: In function 'rsi_reset_card':
> drivers/net/wireless/rsi/rsi_91x_sdio.c:288:20: error: 'MMC_STATE_HIGHSPEED' undeclared (first use in
> this function)
> card->state &= ~MMC_STATE_HIGHSPEED;
> ^
> drivers/net/wireless/rsi/rsi_91x_sdio.c:288:20: note: each undeclared identifier is reported only once
> for each function it appears in
> drivers/net/wireless/rsi/rsi_91x_sdio.c:299:4: error: implicit declaration of function
> 'mmc_card_set_highspeed' [-Werror=implicit-function-declaration]
> mmc_card_set_highspeed(card);
> ^
> drivers/net/wireless/rsi/rsi_91x_sdio.c:306:2: error: implicit declaration of function
> 'mmc_card_highspeed' [-Werror=implicit-function-declaration]
> if (mmc_card_highspeed(card))
> ^
>
> Caused by commit 395784826a81 ("mmc: drop the speed mode of card's state").
>
> I have used the version of the mmc tree from next-20140417 for today.
I didn't detect usage out of mmc-sub for that.
Let me fix and send a patch.
Thanks,
Seungwon Jeon
> --
> Cheers,
> Stephen Rothwell [email protected]
On 22 April 2014 05:06, Stephen Rothwell <[email protected]> wrote:
> Hi Chris,
>
> After merging the mmc tree, today's linux-next build (x86_64 allmodconfig)
> failed like this:
>
> drivers/net/wireless/rsi/rsi_91x_sdio.c: In function 'rsi_reset_card':
> drivers/net/wireless/rsi/rsi_91x_sdio.c:288:20: error: 'MMC_STATE_HIGHSPEED' undeclared (first use in this function)
> card->state &= ~MMC_STATE_HIGHSPEED;
> ^
> drivers/net/wireless/rsi/rsi_91x_sdio.c:288:20: note: each undeclared identifier is reported only once for each function it appears in
> drivers/net/wireless/rsi/rsi_91x_sdio.c:299:4: error: implicit declaration of function 'mmc_card_set_highspeed' [-Werror=implicit-function-declaration]
> mmc_card_set_highspeed(card);
> ^
> drivers/net/wireless/rsi/rsi_91x_sdio.c:306:2: error: implicit declaration of function 'mmc_card_highspeed' [-Werror=implicit-function-declaration]
> if (mmc_card_highspeed(card))
> ^
>
> Caused by commit 395784826a81 ("mmc: drop the speed mode of card's state").
>
> I have used the version of the mmc tree from next-20140417 for today.
Hi Chris,
Until we work out the dependency issue caused by the above commit,
could you please drop the following patches from your mmc-next
branch!?
df1a292 mmc: add support for HS400 mode of eMMC5.0
f27a5d7 mmc: rework selection of bus speed mode
e64f275 mmc: step power class after final selection of bus mode
6371adf mmc: identify available device type to select
3957848 mmc: drop the speed mode of card's state
Kind regards
Ulf Hansson
> --
> Cheers,
> Stephen Rothwell [email protected]
Hi,
On Tue, Apr 22 2014, Ulf Hansson wrote:
> Until we work out the dependency issue caused by the above commit,
> could you please drop the following patches from your mmc-next
> branch!?
>
> df1a292 mmc: add support for HS400 mode of eMMC5.0
> f27a5d7 mmc: rework selection of bus speed mode
> e64f275 mmc: step power class after final selection of bus mode
> 6371adf mmc: identify available device type to select
> 3957848 mmc: drop the speed mode of card's state
Done, thanks.
- Chris.
--
Chris Ball <http://printf.net/>
Hi Chris,
On Mon, 26 May 2014 14:07:35 +1000 Stephen Rothwell <[email protected]> wrote:
>
> After merging the mmc tree, today's linux-next build (arm
> multi_v7_defconfig) failed like this:
>
> drivers/mmc/host/sdhci-s3c.c: In function 'sdhci_s3c_notify_change':
> drivers/mmc/host/sdhci-s3c.c:402:25: error: 'struct sdhci_host' has no member named 'card_tasklet'
>
> Caused by commit 3560db8e247a ("mmc: sdhci: push card_tasklet into
> threaded irq handler"). This is the second left over one I found.
> Please check for any more (grep is your friend).
>
> I have used the mmc tree from next-20140522 again for today.
This is back again. I have no idea why I didn't get this failure on
Friday. Please, guys, go through your tree and fix this problem once
and for all. Grep is your friend.
I have used the mmc tree from next-20140522 again for today.
--
Cheers,
Stephen Rothwell [email protected]
On 30 May 2014 05:23, Stephen Rothwell <[email protected]> wrote:
> Hi Chris,
>
> After merging the mmc tree, today's linux-next build (arm multi_v7_defconfig)
> failed like this:
>
> drivers/mmc/host/sunxi-mmc.c:25:29: fatal error: linux/clk/sunxi.h: No such file or directory
>
> Caused by commit 19b7f796c375 ("mmc: sunxi: Add driver for SD/MMC hosts
> found on Allwinner sunxi SoCs"). Something has changed to turn on
> CONFIG_ARCH_SUNXI in the arm multi_v7_defconfig build since yesterday.
>
> linux/clk/sunxi.h is created by a commit in the clk tree
> (git://git.linaro.org/people/mturquette/linux.git#clk-next) which I
> don't include in linux-next until much later than the mmc tree.
>
> I have reverted that commit for today.
> --
> Cheers,
> Stephen Rothwell [email protected]
Hi Mike, Chris,
So, the proper thing would be to let Mike to carry the above patch
though his clk tree instead.
Could we arrange that?
Kind regards
Ulf Hansson
Hi,
On Mon, Jun 02 2014, Mike Turquette wrote:
>> Hi Mike, Chris,
>>
>> So, the proper thing would be to let Mike to carry the above patch
>> though his clk tree instead.
>>
>> Could we arrange that?
>
> I'm happy to take it with Chris' Acked-by.
Thanks, please do:
Acked-by: Chris Ball <[email protected]>
(Ulf is now MMC co-maintainer so his ack works too.)
- Chris.
--
Chris Ball <http://printf.net/>
Hi Chris,
On Mon, 2 Jun 2014 15:11:41 +1000 Stephen Rothwell <[email protected]> wrote:
>
> On Mon, 26 May 2014 14:07:35 +1000 Stephen Rothwell <[email protected]> wrote:
> >
> > After merging the mmc tree, today's linux-next build (arm
> > multi_v7_defconfig) failed like this:
> >
> > drivers/mmc/host/sdhci-s3c.c: In function 'sdhci_s3c_notify_change':
> > drivers/mmc/host/sdhci-s3c.c:402:25: error: 'struct sdhci_host' has no member named 'card_tasklet'
> >
> > Caused by commit 3560db8e247a ("mmc: sdhci: push card_tasklet into
> > threaded irq handler"). This is the second left over one I found.
> > Please check for any more (grep is your friend).
> >
> > I have used the mmc tree from next-20140522 again for today.
>
> This is back again. I have no idea why I didn't get this failure on
> Friday. Please, guys, go through your tree and fix this problem once
> and for all. Grep is your friend.
>
> I have used the mmc tree from next-20140522 again for today.
Just wondering if you are even receiving my email?
--
Cheers,
Stephen Rothwell [email protected]
Hi Stephen,
On Tue, Jun 03 2014, Stephen Rothwell wrote:
>> This is back again. I have no idea why I didn't get this failure on
>> Friday. Please, guys, go through your tree and fix this problem once
>> and for all. Grep is your friend.
>>
>> I have used the mmc tree from next-20140522 again for today.
>
> Just wondering if you are even receiving my email?
Sorry about this, I'm working on it now.
- Chris.
--
Chris Ball <http://printf.net/>
Hi Stephen,
On Wed, Jun 04 2014, Chris Ball wrote:
> On Tue, Jun 03 2014, Stephen Rothwell wrote:
>>> This is back again. I have no idea why I didn't get this failure on
>>> Friday. Please, guys, go through your tree and fix this problem once
>>> and for all. Grep is your friend.
>>>
>>> I have used the mmc tree from next-20140522 again for today.
>>
>> Just wondering if you are even receiving my email?
>
> Sorry about this, I'm working on it now.
This one's fixed in mmc-next now.
Thanks,
- Chris.
--
Chris Ball <http://printf.net/>