2018-07-26 14:04:01

by Jia-Ju Bai

[permalink] [raw]
Subject: [BUG] staging: lustre: Possible null function pointer in ctx_refresh_timeout()

In Linux-4.16, drivers/staging/lustre/lustre/ptlrp/sec.c,

557. int ctx_refresh_timeout(...) {
            .......
573. req->rq_cli_ctx->cc_ops->force_die(req->rq_cli_ctx, 0);
            ......
575. }

For x86 kernel configuration, there is no assignment of the function
pointer ".force_die" in the kernel code.
So calling the function pointer in line 573 may cause a null pointer
dereference.


Best wishes,
Jia-Ju Bai


2018-07-26 14:14:34

by Greg KH

[permalink] [raw]
Subject: Re: [BUG] staging: lustre: Possible null function pointer in ctx_refresh_timeout()

On Thu, Jul 26, 2018 at 10:02:22PM +0800, Jia-Ju Bai wrote:
> In Linux-4.16, drivers/staging/lustre/lustre/ptlrp/sec.c,

Please look at the 4.18-rc6 release for this file.

In short, nothing to worry about anymore :)

thanks,

greg k-h

2018-07-26 14:20:44

by Jia-Ju Bai

[permalink] [raw]
Subject: Re: [BUG] staging: lustre: Possible null function pointer in ctx_refresh_timeout()



On 2018/7/26 22:12, Greg KH wrote:
> On Thu, Jul 26, 2018 at 10:02:22PM +0800, Jia-Ju Bai wrote:
>> In Linux-4.16, drivers/staging/lustre/lustre/ptlrp/sec.c,
> Please look at the 4.18-rc6 release for this file.
>
> In short, nothing to worry about anymore :)

Looks good now :)


Best wishes,
Jia-Ju Bai