2023-10-18 06:17:54

by Sascha Hauer

Subject: [PATCH v8 12/26] PM / devfreq: rockchip-dfi: Handle LPDDR4X

In the DFI driver LPDDR4X can be handled in the same way as LPDDR4. Add
the missing case.

Reviewed-by: Jonathan Cameron <[email protected]>
Reviewed-by: Sebastian Reichel <[email protected]>
Acked-by: Chanwoo Choi <[email protected]>
Signed-off-by: Sascha Hauer <[email protected]>
---
drivers/devfreq/event/rockchip-dfi.c | 1 +
include/soc/rockchip/rockchip_grf.h | 1 +
2 files changed, 2 insertions(+)

diff --git a/drivers/devfreq/event/rockchip-dfi.c b/drivers/devfreq/event/rockchip-dfi.c
index 8ce0191552ef1..bdf421b248df9 100644
--- a/drivers/devfreq/event/rockchip-dfi.c
+++ b/drivers/devfreq/event/rockchip-dfi.c
@@ -90,6 +90,7 @@ static void rockchip_dfi_start_hardware_counter(struct devfreq_event_dev *edev)
dfi_regs + DDRMON_CTRL);
break;
case ROCKCHIP_DDRTYPE_LPDDR4:
+ case ROCKCHIP_DDRTYPE_LPDDR4X:
writel_relaxed(HIWORD_UPDATE(DDRMON_CTRL_LPDDR4, DDRMON_CTRL_DDR_TYPE_MASK),
dfi_regs + DDRMON_CTRL);
break;
diff --git a/include/soc/rockchip/rockchip_grf.h b/include/soc/rockchip/rockchip_grf.h
index dde1a9796ccb5..e46fd72aea8d1 100644
--- a/include/soc/rockchip/rockchip_grf.h
+++ b/include/soc/rockchip/rockchip_grf.h
@@ -12,6 +12,7 @@ enum {
ROCKCHIP_DDRTYPE_LPDDR2 = 5,
ROCKCHIP_DDRTYPE_LPDDR3 = 6,
ROCKCHIP_DDRTYPE_LPDDR4 = 7,
+ ROCKCHIP_DDRTYPE_LPDDR4X = 8,
};

#endif /* __SOC_ROCKCHIP_GRF_H */
--
2.39.2

2023-10-18 20:02:50

by Heiko Stübner

Subject: Re: [PATCH v8 12/26] PM / devfreq: rockchip-dfi: Handle LPDDR4X

Am Mittwoch, 18. Oktober 2023, 08:17:00 CEST schrieb Sascha Hauer:
> In the DFI driver LPDDR4X can be handled in the same way as LPDDR4. Add
> the missing case.
>
> Reviewed-by: Jonathan Cameron <[email protected]>
> Reviewed-by: Sebastian Reichel <[email protected]>
> Acked-by: Chanwoo Choi <[email protected]>
> Signed-off-by: Sascha Hauer <[email protected]>

Acked-by: Heiko Stuebner <[email protected]>

2023-10-19 11:53:08

by Chanwoo Choi

Subject: RE: [PATCH v8 12/26] PM / devfreq: rockchip-dfi: Handle LPDDR4X

> -----Original Message-----
> From: Sascha Hauer <[email protected]>
> Sent: Wednesday, October 18, 2023 3:17 PM
> To: [email protected]
> Cc: [email protected]; [email protected];
> [email protected]; Heiko Stuebner <[email protected]>; Chanwoo Choi
> <[email protected]>; Kyungmin Park <[email protected]>; MyungJoo
> Ham <[email protected]>; Will Deacon <[email protected]>; Mark
> Rutland <[email protected]>; [email protected]; Michael Riesch
> <[email protected]>; Robin Murphy <[email protected]>;
> Vincent Legoll <[email protected]>; Rob Herring
> <[email protected]>; Krzysztof Kozlowski
> <[email protected]>; Conor Dooley <[email protected]>;
> [email protected]; Sebastian Reichel
> <[email protected]>; Sascha Hauer <[email protected]>;
> Jonathan Cameron <[email protected]>; Chanwoo Choi
> <[email protected]>
> Subject: [PATCH v8 12/26] PM / devfreq: rockchip-dfi: Handle LPDDR4X
>
> In the DFI driver LPDDR4X can be handled in the same way as LPDDR4. Add
> the missing case.
>
> Reviewed-by: Jonathan Cameron <[email protected]>
> Reviewed-by: Sebastian Reichel <[email protected]>
> Acked-by: Chanwoo Choi <[email protected]>
> Signed-off-by: Sascha Hauer <[email protected]>
> ---
> drivers/devfreq/event/rockchip-dfi.c | 1 +
> include/soc/rockchip/rockchip_grf.h | 1 +
> 2 files changed, 2 insertions(+)
>
> diff --git a/drivers/devfreq/event/rockchip-dfi.c
> b/drivers/devfreq/event/rockchip-dfi.c
> index 8ce0191552ef1..bdf421b248df9 100644
> --- a/drivers/devfreq/event/rockchip-dfi.c
> +++ b/drivers/devfreq/event/rockchip-dfi.c
> @@ -90,6 +90,7 @@ static void rockchip_dfi_start_hardware_counter(struct
> devfreq_event_dev *edev)
> dfi_regs + DDRMON_CTRL);
> break;
> case ROCKCHIP_DDRTYPE_LPDDR4:
> + case ROCKCHIP_DDRTYPE_LPDDR4X:
> writel_relaxed(HIWORD_UPDATE(DDRMON_CTRL_LPDDR4,
> DDRMON_CTRL_DDR_TYPE_MASK),
> dfi_regs + DDRMON_CTRL);
> break;
> diff --git a/include/soc/rockchip/rockchip_grf.h
> b/include/soc/rockchip/rockchip_grf.h
> index dde1a9796ccb5..e46fd72aea8d1 100644
> --- a/include/soc/rockchip/rockchip_grf.h
> +++ b/include/soc/rockchip/rockchip_grf.h
> @@ -12,6 +12,7 @@ enum {
> ROCKCHIP_DDRTYPE_LPDDR2 = 5,
> ROCKCHIP_DDRTYPE_LPDDR3 = 6,
> ROCKCHIP_DDRTYPE_LPDDR4 = 7,
> + ROCKCHIP_DDRTYPE_LPDDR4X = 8,
> };
>
> #endif /* __SOC_ROCKCHIP_GRF_H */
> --
> 2.39.2

Applied it. Thanks

Best Regards,
Chanwoo Choi