2023-06-07 12:05:24

by Leonard Göhrs

Subject: [PATCH v1 3/8] dt-bindings: gpio: pca9570: add gpio-line-names property

This patch allows giving each of the controller's pins a meaningful
name.

Signed-off-by: Leonard Göhrs <[email protected]>
---
Documentation/devicetree/bindings/gpio/gpio-pca9570.yaml | 4 ++++
1 file changed, 4 insertions(+)

diff --git a/Documentation/devicetree/bindings/gpio/gpio-pca9570.yaml b/Documentation/devicetree/bindings/gpio/gpio-pca9570.yaml
index 5b0134304e51c..452f8972a9659 100644
--- a/Documentation/devicetree/bindings/gpio/gpio-pca9570.yaml
+++ b/Documentation/devicetree/bindings/gpio/gpio-pca9570.yaml
@@ -24,6 +24,10 @@ properties:
'#gpio-cells':
const: 2

+ gpio-line-names:
+ minItems: 4
+ maxItems: 8
+
required:
- compatible
- reg
--
2.39.2

2023-06-07 16:48:38

by Andy Shevchenko

Subject: Re: [PATCH v1 3/8] dt-bindings: gpio: pca9570: add gpio-line-names property

Wed, Jun 07, 2023 at 01:55:02PM +0200, Leonard G?hrs kirjoitti:
> This patch allows giving each of the controller's pins a meaningful
> name.

Isn't it gpio.txt already mentiones this?
Perhaps you need to convert that to YAML and use it here?

--
With Best Regards,
Andy Shevchenko

2023-06-08 13:33:28

by Krzysztof Kozlowski

Subject: Re: [PATCH v1 3/8] dt-bindings: gpio: pca9570: add gpio-line-names property

On 07/06/2023 13:55, Leonard Göhrs wrote:
> This patch allows giving each of the controller's pins a meaningful
> name.
>
> Signed-off-by: Leonard Göhrs <[email protected]>
> ---


Acked-by: Krzysztof Kozlowski <[email protected]>

Best regards,
Krzysztof

2023-06-08 13:38:58

by Krzysztof Kozlowski

Subject: Re: [PATCH v1 3/8] dt-bindings: gpio: pca9570: add gpio-line-names property

On 07/06/2023 18:36, [email protected] wrote:
> Wed, Jun 07, 2023 at 01:55:02PM +0200, Leonard Göhrs kirjoitti:
>> This patch allows giving each of the controller's pins a meaningful
>> name.
>
> Isn't it gpio.txt already mentiones this?

TXT does not matter for DT schema. It's is already covered by dtschemas.

> Perhaps you need to convert that to YAML and use it here?

How would it solve anything? We still want constraints, right?

Best regards,
Krzysztof

2023-06-13 15:35:21

by Bartosz Golaszewski

Subject: Re: [PATCH v1 3/8] dt-bindings: gpio: pca9570: add gpio-line-names property

On Wed, Jun 7, 2023 at 1:57 PM Leonard Göhrs <[email protected]> wrote:
>
> This patch allows giving each of the controller's pins a meaningful
> name.
>
> Signed-off-by: Leonard Göhrs <[email protected]>
> ---
> Documentation/devicetree/bindings/gpio/gpio-pca9570.yaml | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/gpio/gpio-pca9570.yaml b/Documentation/devicetree/bindings/gpio/gpio-pca9570.yaml
> index 5b0134304e51c..452f8972a9659 100644
> --- a/Documentation/devicetree/bindings/gpio/gpio-pca9570.yaml
> +++ b/Documentation/devicetree/bindings/gpio/gpio-pca9570.yaml
> @@ -24,6 +24,10 @@ properties:
> '#gpio-cells':
> const: 2
>
> + gpio-line-names:
> + minItems: 4
> + maxItems: 8
> +
> required:
> - compatible
> - reg
> --
> 2.39.2
>

Applied, thanks!

Bart