2004-01-16 15:53:33

by Maciej Soltysiak

Subject: [PATCH 2.6] Re: Linux 2.4.25-pre6

> o [IPV4]: Print correct source addr in invalid ICMP msgs, from Dennis
Jorgensen
Oh, and the same patch should be applied to 2.6 too.

Regards,
Maciej

dns:/usr/src/linux/net/ipv4# diff -u icmp.c~ icmp.c
--- icmp.c~ 2003-12-18 03:59:40.000000000 +0100
+++ icmp.c 2004-01-16 16:47:28.000000000 +0100
@@ -670,7 +670,7 @@
printk(KERN_WARNING "%u.%u.%u.%u sent an invalid
ICMP "
"type %u, code %u "
"error to a broadcast:
%u.%u.%u.%u on %s\n",
- NIPQUAD(skb->nh.iph->saddr),
+ NIPQUAD(iph->saddr),
icmph->type, icmph->code,
NIPQUAD(iph->daddr),
skb->dev->name);

2004-01-16 18:14:59

by Mike Fedyk

Subject: Re: [PATCH 2.6] Re: Linux 2.4.25-pre6

On Fri, Jan 16, 2004 at 04:52:49PM +0100, Maciej Soltysiak wrote:
> > o [IPV4]: Print correct source addr in invalid ICMP msgs, from Dennis
> Jorgensen
> Oh, and the same patch should be applied to 2.6 too.
>
> Regards,
> Maciej
>
> dns:/usr/src/linux/net/ipv4# diff -u icmp.c~ icmp.c
> --- icmp.c~ 2003-12-18 03:59:40.000000000 +0100
> +++ icmp.c 2004-01-16 16:47:28.000000000 +0100
> @@ -670,7 +670,7 @@
> printk(KERN_WARNING "%u.%u.%u.%u sent an invalid
> ICMP "
> "type %u, code %u "
> "error to a broadcast:
> %u.%u.%u.%u on %s\n",
> - NIPQUAD(skb->nh.iph->saddr),
> + NIPQUAD(iph->saddr),

Looks like it wrapped...