2020-05-26 02:28:52

by Jingle.Wu

Subject: [PATCH] Input: elantech - Remove read/write registers in attr.

New Elan IC would not be accessed with the specific regiters.

Signed-off-by: Jingle Wu <[email protected]>
---
drivers/input/mouse/elantech.c | 20 --------------------
1 file changed, 20 deletions(-)

diff --git a/drivers/input/mouse/elantech.c b/drivers/input/mouse/elantech.c
index 2d8434b7b623..fa1aa5f441f5 100644
--- a/drivers/input/mouse/elantech.c
+++ b/drivers/input/mouse/elantech.c
@@ -1280,31 +1280,11 @@ static ssize_t elantech_set_int_attr(struct psmouse *psmouse,
elantech_show_int_attr, \
elantech_set_int_attr)

-ELANTECH_INT_ATTR(reg_07, 0x07);
-ELANTECH_INT_ATTR(reg_10, 0x10);
-ELANTECH_INT_ATTR(reg_11, 0x11);
-ELANTECH_INT_ATTR(reg_20, 0x20);
-ELANTECH_INT_ATTR(reg_21, 0x21);
-ELANTECH_INT_ATTR(reg_22, 0x22);
-ELANTECH_INT_ATTR(reg_23, 0x23);
-ELANTECH_INT_ATTR(reg_24, 0x24);
-ELANTECH_INT_ATTR(reg_25, 0x25);
-ELANTECH_INT_ATTR(reg_26, 0x26);
ELANTECH_INFO_ATTR(debug);
ELANTECH_INFO_ATTR(paritycheck);
ELANTECH_INFO_ATTR(crc_enabled);

static struct attribute *elantech_attrs[] = {
- &psmouse_attr_reg_07.dattr.attr,
- &psmouse_attr_reg_10.dattr.attr,
- &psmouse_attr_reg_11.dattr.attr,
- &psmouse_attr_reg_20.dattr.attr,
- &psmouse_attr_reg_21.dattr.attr,
- &psmouse_attr_reg_22.dattr.attr,
- &psmouse_attr_reg_23.dattr.attr,
- &psmouse_attr_reg_24.dattr.attr,
- &psmouse_attr_reg_25.dattr.attr,
- &psmouse_attr_reg_26.dattr.attr,
&psmouse_attr_debug.dattr.attr,
&psmouse_attr_paritycheck.dattr.attr,
&psmouse_attr_crc_enabled.dattr.attr,
--
2.17.1

2020-05-26 04:20:17

by Dmitry Torokhov

Subject: Re: [PATCH] Input: elantech - Remove read/write registers in attr.

Hi Jingle,

On Tue, May 26, 2020 at 10:22:46AM +0800, Jingle.Wu wrote:
> New Elan IC would not be accessed with the specific regiters.

What about older Elaan parts? We can't simply drop compatibility with
older chips in newer kernels.

Thanks.

--
Dmitry

2020-05-26 06:56:47

by Jingle.Wu

Subject: RE: [PATCH] Input: elantech - Remove read/write registers in attr.

HI Dmitry:

These changes would not affect all the behavior of the old IC, including all
the TP functions

THANKS
JINGLE

-----Original Message-----
From: Dmitry Torokhov [mailto:[email protected]]
Sent: Tuesday, May 26, 2020 12:17 PM
To: Jingle.Wu
Cc: [email protected]; [email protected];
[email protected]; [email protected]; [email protected]
Subject: Re: [PATCH] Input: elantech - Remove read/write registers in attr.

Hi Jingle,

On Tue, May 26, 2020 at 10:22:46AM +0800, Jingle.Wu wrote:
> New Elan IC would not be accessed with the specific regiters.

What about older Elaan parts? We can't simply drop compatibility with older
chips in newer kernels.

Thanks.

--
Dmitry