2014-07-23 07:41:59

by Kiran Padwal

Subject: [PATCH] usb: phy: msm: Make of_device_id array const

Make of_device_id array const, because all OF functions handle it as const.

Signed-off-by: Kiran Padwal <[email protected]>
---
drivers/usb/phy/phy-msm-usb.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/usb/phy/phy-msm-usb.c b/drivers/usb/phy/phy-msm-usb.c
index 78cc870..e4108ee 100644
--- a/drivers/usb/phy/phy-msm-usb.c
+++ b/drivers/usb/phy/phy-msm-usb.c
@@ -1429,7 +1429,7 @@ static void msm_otg_debugfs_cleanup(void)
debugfs_remove(msm_otg_dbg_root);
}

-static struct of_device_id msm_otg_dt_match[] = {
+static const struct of_device_id msm_otg_dt_match[] = {
{
.compatible = "qcom,usb-otg-ci",
.data = (void *) CI_45NM_INTEGRATED_PHY
--
1.7.9.5

2014-07-23 09:18:16

by Jingoo Han

Subject: Re: [PATCH] usb: phy: msm: Make of_device_id array const

On Wednesday, July 23, 2014 4:38 PM, Kiran Padwal wrote:
>
> Make of_device_id array const, because all OF functions handle it as const.

Hi Kiran Padwal,

The same patch was already submitted and merged to USB tree.
Thank you.

Best regards,
Jingoo Han

>
> Signed-off-by: Kiran Padwal <[email protected]>
> ---
> drivers/usb/phy/phy-msm-usb.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/usb/phy/phy-msm-usb.c b/drivers/usb/phy/phy-msm-usb.c
> index 78cc870..e4108ee 100644
> --- a/drivers/usb/phy/phy-msm-usb.c
> +++ b/drivers/usb/phy/phy-msm-usb.c
> @@ -1429,7 +1429,7 @@ static void msm_otg_debugfs_cleanup(void)
> debugfs_remove(msm_otg_dbg_root);
> }
>
> -static struct of_device_id msm_otg_dt_match[] = {
> +static const struct of_device_id msm_otg_dt_match[] = {
> {
> .compatible = "qcom,usb-otg-ci",
> .data = (void *) CI_45NM_INTEGRATED_PHY
> --
> 1.7.9.5

2014-07-23 09:42:18

by Kiran Padwal

Subject: Re: [PATCH] usb: phy: msm: Make of_device_id array const

On Wed, Jul 23, 2014 at 2:48 PM, Jingoo Han <[email protected]> wrote:
> On Wednesday, July 23, 2014 4:38 PM, Kiran Padwal wrote:
>>
>> Make of_device_id array const, because all OF functions handle it as const.
>
> Hi Kiran Padwal,
>
> The same patch was already submitted and merged to USB tree.
> Thank you.

Thanks.

>
> Best regards,
> Jingoo Han
>
>>
>> Signed-off-by: Kiran Padwal <[email protected]>
>> ---
>> drivers/usb/phy/phy-msm-usb.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/usb/phy/phy-msm-usb.c b/drivers/usb/phy/phy-msm-usb.c
>> index 78cc870..e4108ee 100644
>> --- a/drivers/usb/phy/phy-msm-usb.c
>> +++ b/drivers/usb/phy/phy-msm-usb.c
>> @@ -1429,7 +1429,7 @@ static void msm_otg_debugfs_cleanup(void)
>> debugfs_remove(msm_otg_dbg_root);
>> }
>>
>> -static struct of_device_id msm_otg_dt_match[] = {
>> +static const struct of_device_id msm_otg_dt_match[] = {
>> {
>> .compatible = "qcom,usb-otg-ci",
>> .data = (void *) CI_45NM_INTEGRATED_PHY
>> --
>> 1.7.9.5
>