2018-06-21 02:44:42

by Katsuhiro Suzuki

Subject: [PATCH] ASoC: uniphier: remove redundant check of PLL ID

This patch removes redudant check of PLL ID. struct uniphier_aio_pll
enable member has already been checked at is_valid_pll().

Signed-off-by: Katsuhiro Suzuki <[email protected]>
---
sound/soc/uniphier/aio-cpu.c | 4 ----
1 file changed, 4 deletions(-)

diff --git a/sound/soc/uniphier/aio-cpu.c b/sound/soc/uniphier/aio-cpu.c
index 2d9b7dde2ffa..cfe69ab44b63 100644
--- a/sound/soc/uniphier/aio-cpu.c
+++ b/sound/soc/uniphier/aio-cpu.c
@@ -224,10 +224,6 @@ static int uniphier_aio_set_pll(struct snd_soc_dai *dai, int pll_id,

if (!is_valid_pll(aio->chip, pll_id))
return -EINVAL;
- if (!aio->chip->plls[pll_id].enable) {
- dev_err(dev, "PLL(%d) is not implemented\n", pll_id);
- return -ENOTSUPP;
- }

ret = aio_chip_set_pll(aio->chip, pll_id, freq_out);
if (ret < 0)
--
2.17.1

2018-06-21 02:55:40

by Katsuhiro Suzuki

Subject: Re: [PATCH] ASoC: uniphier: remove redundant check of PLL ID

Hello,

I got mistake (forget to remove unused variable).
I'll send v2. Sorry for confusing.

Regards,
--
Katsuhiro Suzuki


> -----Original Message-----
> From: Katsuhiro Suzuki <[email protected]>
> Sent: Thursday, June 21, 2018 11:44 AM
> To: Mark Brown <[email protected]>; [email protected]
> Cc: Masami Hiramatsu <[email protected]>; Jassi Brar
> <[email protected]>; [email protected];
> [email protected]; Suzuki, Katsuhiro/$BNkLZ(B $B>!Gn(B
> <[email protected]>
> Subject: [PATCH] ASoC: uniphier: remove redundant check of PLL ID
>
> This patch removes redudant check of PLL ID. struct uniphier_aio_pll
> enable member has already been checked at is_valid_pll().
>
> Signed-off-by: Katsuhiro Suzuki <[email protected]>
> ---
> sound/soc/uniphier/aio-cpu.c | 4 ----
> 1 file changed, 4 deletions(-)
>
> diff --git a/sound/soc/uniphier/aio-cpu.c b/sound/soc/uniphier/aio-cpu.c
> index 2d9b7dde2ffa..cfe69ab44b63 100644
> --- a/sound/soc/uniphier/aio-cpu.c
> +++ b/sound/soc/uniphier/aio-cpu.c
> @@ -224,10 +224,6 @@ static int uniphier_aio_set_pll(struct snd_soc_dai *dai,
int
> pll_id,
>
> if (!is_valid_pll(aio->chip, pll_id))
> return -EINVAL;
> - if (!aio->chip->plls[pll_id].enable) {
> - dev_err(dev, "PLL(%d) is not implemented\n", pll_id);
> - return -ENOTSUPP;
> - }
>
> ret = aio_chip_set_pll(aio->chip, pll_id, freq_out);
> if (ret < 0)
> --
> 2.17.1