2013-08-08 09:37:31

by Cho KyongHo

Subject: [PATCH v9 01/16] iommu/exynos: do not include removed header

This commit remove <mach/sysmmu.h> which is removed.

Signed-off-by: Cho KyongHo <[email protected]>
---
drivers/iommu/exynos-iommu.c | 3 +--
1 files changed, 1 insertions(+), 2 deletions(-)

diff --git a/drivers/iommu/exynos-iommu.c b/drivers/iommu/exynos-iommu.c
index 3f32d64..233f382 100644
--- a/drivers/iommu/exynos-iommu.c
+++ b/drivers/iommu/exynos-iommu.c
@@ -12,6 +12,7 @@
#define DEBUG
#endif

+#include <linux/kernel.h>
#include <linux/io.h>
#include <linux/interrupt.h>
#include <linux/platform_device.h>
@@ -29,8 +30,6 @@
#include <asm/cacheflush.h>
#include <asm/pgtable.h>

-#include <mach/sysmmu.h>
-
/* We does not consider super section mapping (16MB) */
#define SECT_ORDER 20
#define LPAGE_ORDER 16
--
1.7.2.5

2013-08-08 13:42:31

by Tomasz Figa

Subject: Re: [PATCH v9 01/16] iommu/exynos: do not include removed header

Hi KyongHo,

On Thursday 08 of August 2013 18:37:25 Cho KyongHo wrote:
> This commit remove <mach/sysmmu.h> which is removed.

I would prefer a more meaningful commit message, something among following
lines:

8<---
Commit 25e9d28d92 (ARM: EXYNOS: remove system mmu initialization from
exynos tree) removed arch/arm/mach-exynos/mach/sysmmu.h header without
removing remaining use of it from exynos-iommu driver, thus causing a
compilation error.

This patch fixes the error by removing respective include line from exynos-
iommu.c.
--->8

Also a sentence explaining why linux/kernel.h header must be included would
be nice.

> Signed-off-by: Cho KyongHo <[email protected]>

Please note that as far as I'm aware of, tags should be made using western
name writing convention, i.e. starting with first name.

Best regards,
Tomasz

> ---
> drivers/iommu/exynos-iommu.c | 3 +--
> 1 files changed, 1 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/iommu/exynos-iommu.c b/drivers/iommu/exynos-iommu.c
> index 3f32d64..233f382 100644
> --- a/drivers/iommu/exynos-iommu.c
> +++ b/drivers/iommu/exynos-iommu.c
> @@ -12,6 +12,7 @@
> #define DEBUG
> #endif
>
> +#include <linux/kernel.h>
> #include <linux/io.h>
> #include <linux/interrupt.h>
> #include <linux/platform_device.h>
> @@ -29,8 +30,6 @@
> #include <asm/cacheflush.h>
> #include <asm/pgtable.h>
>
> -#include <mach/sysmmu.h>
> -
> /* We does not consider super section mapping (16MB) */
> #define SECT_ORDER 20
> #define LPAGE_ORDER 16

2013-08-09 04:01:41

by Cho KyongHo

Subject: Re: [PATCH v9 01/16] iommu/exynos: do not include removed header

On Thu, 08 Aug 2013 15:42:24 +0200, Tomasz Figa wrote:
> Hi KyongHo,
>
> On Thursday 08 of August 2013 18:37:25 Cho KyongHo wrote:
> > This commit remove <mach/sysmmu.h> which is removed.
>
> I would prefer a more meaningful commit message, something among following
> lines:
>
> 8<---
> Commit 25e9d28d92 (ARM: EXYNOS: remove system mmu initialization from
> exynos tree) removed arch/arm/mach-exynos/mach/sysmmu.h header without
> removing remaining use of it from exynos-iommu driver, thus causing a
> compilation error.
>
> This patch fixes the error by removing respective include line from exynos-
> iommu.c.
> --->8
>

Ok.

> Also a sentence explaining why linux/kernel.h header must be included would
> be nice.
>
> > Signed-off-by: Cho KyongHo <[email protected]>
>
> Please note that as far as I'm aware of, tags should be made using western
> name writing convention, i.e. starting with first name.
>

Oh, I didn't think that the order of family/given names are the matter.
I don't care about changing the order.

Thanks.

KyongHo.

> Best regards,
> Tomasz
>
> > ---
> > drivers/iommu/exynos-iommu.c | 3 +--
> > 1 files changed, 1 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/iommu/exynos-iommu.c b/drivers/iommu/exynos-iommu.c
> > index 3f32d64..233f382 100644
> > --- a/drivers/iommu/exynos-iommu.c
> > +++ b/drivers/iommu/exynos-iommu.c
> > @@ -12,6 +12,7 @@
> > #define DEBUG
> > #endif
> >
> > +#include <linux/kernel.h>
> > #include <linux/io.h>
> > #include <linux/interrupt.h>
> > #include <linux/platform_device.h>
> > @@ -29,8 +30,6 @@
> > #include <asm/cacheflush.h>
> > #include <asm/pgtable.h>
> >
> > -#include <mach/sysmmu.h>
> > -
> > /* We does not consider super section mapping (16MB) */
> > #define SECT_ORDER 20
> > #define LPAGE_ORDER 16