2020-06-26 18:54:38

by Rakesh Pillai

[permalink] [raw]
Subject: [PATCH v2 0/2] ath10k: Fixes during subsystem recovery

This patch series includes some fixes when the device
is in recovery mode, i.e. when the firmware goes down.

- Pausing TX queues when FW goes down
- Removed unwanted/extra error logging in pkt TX path
- Skipping wait for FW response for delete cmds
- Handling the -ESHUTDOWN error code in case of SSR.

Rakesh Pillai (2):
ath10k: Pause the tx queues when firmware is down
ath10k: Skip wait for delete response if firmware is down

drivers/net/wireless/ath/ath10k/core.h | 1 +
drivers/net/wireless/ath/ath10k/mac.c | 36 ++++++++++++++++++++++------------
drivers/net/wireless/ath/ath10k/snoc.c | 3 +++
3 files changed, 28 insertions(+), 12 deletions(-)

--
2.7.4


2021-02-26 14:44:42

by Rakesh Pillai

[permalink] [raw]
Subject: RE: [PATCH v2 0/2] ath10k: Fixes during subsystem recovery



> -----Original Message-----
> From: Rakesh Pillai <[email protected]>
> Sent: Friday, January 15, 2021 6:56 PM
> To: 'Kalle Valo' <[email protected]>
> Cc: '[email protected]' <[email protected]>; 'linux-
> [email protected]' <[email protected]>; 'linux-
> [email protected]' <[email protected]>
> Subject: RE: [PATCH v2 0/2] ath10k: Fixes during subsystem recovery
>
>
> > -----Original Message-----
> > From: Kalle Valo <[email protected]>
> > Sent: Tuesday, December 22, 2020 12:07 AM
> > To: Rakesh Pillai <[email protected]>
> > Cc: [email protected]; [email protected]; linux-
> > [email protected]
> > Subject: Re: [PATCH v2 0/2] ath10k: Fixes during subsystem recovery
> >
> > Rakesh Pillai <[email protected]> writes:
> >
> > > This patch series includes some fixes when the device
> > > is in recovery mode, i.e. when the firmware goes down.
> > >
> > > - Pausing TX queues when FW goes down
> > > - Removed unwanted/extra error logging in pkt TX path
> > > - Skipping wait for FW response for delete cmds
> > > - Handling the -ESHUTDOWN error code in case of SSR.
> > >
> > > Rakesh Pillai (2):
> > > ath10k: Pause the tx queues when firmware is down
> > > ath10k: Skip wait for delete response if firmware is down
> >
> > This has been tested only on WCN3990. How do I know that this doesn't
> > break other hardware families?
>
> " ath10k: Pause the tx queues when firmware is down"
> This is done only for SNOC (wcn3990) target and does not affect other
> targets.
>
> " ath10k: Skip wait for delete response if firmware is down"
> The skip for wmi responses is done based on the flag
> "ATH10K_FLAG_CRASH_FLUSH", which is generic for all targets.
> Since if the FW is down, there wont be any response from the FW for any
> target.
>

Hi Kalle,
I see that these patches are in "deferred" state. Is there any info/change
needed in this patch ?

Thanks,
Rakesh Pillai.