2023-10-18 06:17:48

by Sascha Hauer

Subject: [PATCH v8 21/26] dt-bindings: devfreq: event: rockchip,dfi: Add rk3568 support

This adds the rockchip,rk3568-dfi compatible to the binding. Make clocks
optional for this SoC as the RK3568 doesn't have a kernel controllable
PCLK.

Reviewed-by: Conor Dooley <[email protected]>
Acked-by: Chanwoo Choi <[email protected]>
Signed-off-by: Sascha Hauer <[email protected]>
---
.../bindings/devfreq/event/rockchip,dfi.yaml | 15 +++++++++++++--
1 file changed, 13 insertions(+), 2 deletions(-)

diff --git a/Documentation/devicetree/bindings/devfreq/event/rockchip,dfi.yaml b/Documentation/devicetree/bindings/devfreq/event/rockchip,dfi.yaml
index 7a82f6ae0701e..e8b64494ee8bd 100644
--- a/Documentation/devicetree/bindings/devfreq/event/rockchip,dfi.yaml
+++ b/Documentation/devicetree/bindings/devfreq/event/rockchip,dfi.yaml
@@ -13,6 +13,7 @@ properties:
compatible:
enum:
- rockchip,rk3399-dfi
+ - rockchip,rk3568-dfi

clocks:
maxItems: 1
@@ -34,11 +35,21 @@ properties:

required:
- compatible
- - clocks
- - clock-names
- interrupts
- reg

+if:
+ properties:
+ compatible:
+ contains:
+ enum:
+ - rockchip,rk3399-dfi
+
+then:
+ required:
+ - clocks
+ - clock-names
+
additionalProperties: false

examples:
--
2.39.2

2023-10-19 12:27:27

by Chanwoo Choi

Subject: RE: [PATCH v8 21/26] dt-bindings: devfreq: event: rockchip,dfi: Add rk3568 support

> -----Original Message-----
> From: Sascha Hauer <[email protected]>
> Sent: Wednesday, October 18, 2023 3:17 PM
> To: [email protected]
> Cc: [email protected]; [email protected];
> [email protected]; Heiko Stuebner <[email protected]>; Chanwoo Choi
> <[email protected]>; Kyungmin Park <[email protected]>; MyungJoo
> Ham <[email protected]>; Will Deacon <[email protected]>; Mark
> Rutland <[email protected]>; [email protected]; Michael Riesch
> <[email protected]>; Robin Murphy <[email protected]>;
> Vincent Legoll <[email protected]>; Rob Herring
> <[email protected]>; Krzysztof Kozlowski
> <[email protected]>; Conor Dooley <[email protected]>;
> [email protected]; Sebastian Reichel
> <[email protected]>; Sascha Hauer <[email protected]>;
> Conor Dooley <[email protected]>; Chanwoo Choi
> <[email protected]>
> Subject: [PATCH v8 21/26] dt-bindings: devfreq: event: rockchip,dfi: Add
> rk3568 support
>
> This adds the rockchip,rk3568-dfi compatible to the binding. Make clocks
> optional for this SoC as the RK3568 doesn't have a kernel controllable
> PCLK.
>
> Reviewed-by: Conor Dooley <[email protected]>
> Acked-by: Chanwoo Choi <[email protected]>
> Signed-off-by: Sascha Hauer <[email protected]>
> ---
> .../bindings/devfreq/event/rockchip,dfi.yaml | 15 +++++++++++++--
> 1 file changed, 13 insertions(+), 2 deletions(-)
>
> diff --git
> a/Documentation/devicetree/bindings/devfreq/event/rockchip,dfi.yaml
> b/Documentation/devicetree/bindings/devfreq/event/rockchip,dfi.yaml
> index 7a82f6ae0701e..e8b64494ee8bd 100644
> --- a/Documentation/devicetree/bindings/devfreq/event/rockchip,dfi.yaml
> +++ b/Documentation/devicetree/bindings/devfreq/event/rockchip,dfi.yaml
> @@ -13,6 +13,7 @@ properties:
> compatible:
> enum:
> - rockchip,rk3399-dfi
> + - rockchip,rk3568-dfi
>
> clocks:
> maxItems: 1
> @@ -34,11 +35,21 @@ properties:
>
> required:
> - compatible
> - - clocks
> - - clock-names
> - interrupts
> - reg
>
> +if:
> + properties:
> + compatible:
> + contains:
> + enum:
> + - rockchip,rk3399-dfi
> +
> +then:
> + required:
> + - clocks
> + - clock-names
> +
> additionalProperties: false
>
> examples:
> --
> 2.39.2


Applied it. Thanks

Best Regards,
Chanwoo Choi