2024-02-05 09:45:17

by Alexey Dobriyan

[permalink] [raw]
Subject: [PATCH] smp: make __smp_processor_id() 0-argument macro

smp_processor_id family of macros never accepted any arguments.

#define __smp_processor_id(x)

works by accident (see C99 6.10.3 §4). __smp_processor_id() gets
1 (empty) argument and passes it down to raw_smp_processor_id()
which doesn't accept arguments.

Signed-off-by: Alexey Dobriyan <[email protected]>
---

include/linux/smp.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

--- a/include/linux/smp.h
+++ b/include/linux/smp.h
@@ -261,7 +261,7 @@ static inline int get_boot_cpu_id(void)
* regular asm read for the stable.
*/
#ifndef __smp_processor_id
-#define __smp_processor_id(x) raw_smp_processor_id(x)
+#define __smp_processor_id() raw_smp_processor_id()
#endif

#ifdef CONFIG_DEBUG_PREEMPT


Subject: [tip: smp/core] smp: Make __smp_processor_id() 0-argument macro

The following commit has been merged into the smp/core branch of tip:

Commit-ID: b57b4126dd3bb69db876ae7b271307ab7e0458b9
Gitweb: https://git.kernel.org/tip/b57b4126dd3bb69db876ae7b271307ab7e0458b9
Author: Alexey Dobriyan <[email protected]>
AuthorDate: Mon, 05 Feb 2024 12:39:30 +03:00
Committer: Thomas Gleixner <[email protected]>
CommitterDate: Mon, 19 Feb 2024 18:05:47 +01:00

smp: Make __smp_processor_id() 0-argument macro

smp_processor_id family of macros never accepted any arguments.

#define __smp_processor_id(x)

works by accident (see C99 6.10.3 §4). __smp_processor_id() gets
1 (empty) argument and passes it down to raw_smp_processor_id()
which doesn't accept arguments.

Signed-off-by: Alexey Dobriyan <[email protected]>
Signed-off-by: Thomas Gleixner <[email protected]>
Link: https://lore.kernel.org/r/0037d1f2-8153-4b33-b43e-f4b6ecd710ac@p183

---
include/linux/smp.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/include/linux/smp.h b/include/linux/smp.h
index e87520d..cc51700 100644
--- a/include/linux/smp.h
+++ b/include/linux/smp.h
@@ -261,7 +261,7 @@ static inline int get_boot_cpu_id(void)
* regular asm read for the stable.
*/
#ifndef __smp_processor_id
-#define __smp_processor_id(x) raw_smp_processor_id(x)
+#define __smp_processor_id() raw_smp_processor_id()
#endif

#ifdef CONFIG_DEBUG_PREEMPT