> -----Original Message-----
> From: Takashi Iwai <[email protected]>
> Sent: Friday, September 22, 2023 3:36 PM
> To: Stefan Binding <[email protected]>
> Cc: Mark Brown <[email protected]>; Jaroslav Kysela
> <[email protected]>; Takashi Iwai <[email protected]>; alsa-devel@alsa-
> project.org; [email protected];
> [email protected]
> Subject: Re: [PATCH v1 0/2] ALSA: cs35l41: prevent old firmwares
using
> unsupported commands
>
> On Fri, 22 Sep 2023 16:28:16 +0200,
> Stefan Binding wrote:
> >
> > Some systems use older firmware which does not support newer
> commands
> > which are used to enable external boost. For those systems, we can
> > workaround this by writing the registers directly.
> >
> > We can use the firmware version, stored inside cs_dsp, to
determine
> > whether or not the command is supported.
> > To achieve this, it requires a cleanup in the api, to pass the
cs_dsp
> > struct into the function.
> >
> > We can also remove the redundant boolean firmware_running from the
> HDA
> > driver, and use the equivalent state inside cs_dsp.
>
> So those are fixes needed for 6.6 kernel? Or they are something
new?
These are to fix the issue that was reported on the Lenovo Legion 7
16ACHg6,
which was introduced after the fixes to CS35L41 HDA System Suspend.
Thanks,
Stefan
>
> > This chain is based on Mark's branch, since the api change was
made to
> > the function in sound/soc/codecs/cs35l41-lib.c.
>
> I'd need a PR from Mark before applying those, then.
>
>
> thanks,
>
> Takashi