2010-08-30 11:47:20

by Kyungmin Park

Subject: [PATCH 1/3] ARM: Samsung S5P: Move the common Samsung S5P series GPIO level type

From: Kyungmin Park <[email protected]>

Samsung S5P series has common level type. It's different from S3C series.

Signed-off-by: Kyungmin Park <[email protected]>
---
arch/arm/plat-samsung/include/plat/gpio-core.h | 6 ++++++
1 files changed, 6 insertions(+), 0 deletions(-)

diff --git a/arch/arm/plat-samsung/include/plat/gpio-core.h b/arch/arm/plat-samsung/include/plat/gpio-core.h
index e358c7d..c8681e0 100644
--- a/arch/arm/plat-samsung/include/plat/gpio-core.h
+++ b/arch/arm/plat-samsung/include/plat/gpio-core.h
@@ -14,6 +14,12 @@
#define GPIOCON_OFF (0x00)
#define GPIODAT_OFF (0x04)

+#define S5P_GPIO_LEVEL_LOW (0x00)
+#define S5P_GPIO_LEVEL_HIGH (0x01)
+#define S5P_GPIO_EDGE_FALLING (0x02)
+#define S5P_GPIO_EDGE_RISING (0x03)
+#define S5P_GPIO_EDGE_BOTH (0x04)
+
#define con_4bit_shift(__off) ((__off) * 4)

/* Define the core gpiolib support functions that the s3c platforms may
--
1.5.3.3

2010-08-30 12:00:10

by Sergei Shtylyov

Subject: Re: [PATCH 1/3] ARM: Samsung S5P: Move the common Samsung S5P series GPIO level type

Hello.

Kyungmin Park wrote:

> From: Kyungmin Park <[email protected]>

> Samsung S5P series has common level type. It's different from S3C series.

> Signed-off-by: Kyungmin Park <[email protected]>

[...]

> diff --git a/arch/arm/plat-samsung/include/plat/gpio-core.h b/arch/arm/plat-samsung/include/plat/gpio-core.h
> index e358c7d..c8681e0 100644
> --- a/arch/arm/plat-samsung/include/plat/gpio-core.h
> +++ b/arch/arm/plat-samsung/include/plat/gpio-core.h
> @@ -14,6 +14,12 @@
> #define GPIOCON_OFF (0x00)
> #define GPIODAT_OFF (0x04)
>
> +#define S5P_GPIO_LEVEL_LOW (0x00)
> +#define S5P_GPIO_LEVEL_HIGH (0x01)
> +#define S5P_GPIO_EDGE_FALLING (0x02)
> +#define S5P_GPIO_EDGE_RISING (0x03)
> +#define S5P_GPIO_EDGE_BOTH (0x04)

The parens are useless here.

WBR, Sergei

2010-08-30 12:01:05

by Kukjin Kim

Subject: RE: [PATCH 1/3] ARM: Samsung S5P: Move the common Samsung S5P series GPIO level type

Kyungmin Park wrote:
>
> From: Kyungmin Park <[email protected]>
>
> Samsung S5P series has common level type. It's different from S3C series.
>
> Signed-off-by: Kyungmin Park <[email protected]>
> ---
> arch/arm/plat-samsung/include/plat/gpio-core.h | 6 ++++++
> 1 files changed, 6 insertions(+), 0 deletions(-)
>
> diff --git a/arch/arm/plat-samsung/include/plat/gpio-core.h
b/arch/arm/plat-
> samsung/include/plat/gpio-core.h
> index e358c7d..c8681e0 100644
> --- a/arch/arm/plat-samsung/include/plat/gpio-core.h
> +++ b/arch/arm/plat-samsung/include/plat/gpio-core.h
> @@ -14,6 +14,12 @@
> #define GPIOCON_OFF (0x00)
> #define GPIODAT_OFF (0x04)
>
> +#define S5P_GPIO_LEVEL_LOW (0x00)
> +#define S5P_GPIO_LEVEL_HIGH (0x01)
> +#define S5P_GPIO_EDGE_FALLING (0x02)
> +#define S5P_GPIO_EDGE_RISING (0x03)
> +#define S5P_GPIO_EDGE_BOTH (0x04)

Why should we change the name of definition from S5P_EXTINT_XXX?
If we use that, we don't need to change other files.

> +
> #define con_4bit_shift(__off) ((__off) * 4)
>
> /* Define the core gpiolib support functions that the s3c platforms may
> --

Thanks.

Best regards,
Kgene.
--
Kukjin Kim <[email protected]>, Senior Engineer,
SW Solution Development Team, Samsung Electronics Co., Ltd.

2010-08-30 13:35:31

by Kyungmin Park

Subject: Re: [PATCH 1/3] ARM: Samsung S5P: Move the common Samsung S5P series GPIO level type

On Mon, Aug 30, 2010 at 9:01 PM, Kukjin Kim <[email protected]> wrote:
> Kyungmin Park wrote:
>>
>> From: Kyungmin Park <[email protected]>
>>
>> Samsung S5P series has common level type. It's different from S3C series.
>>
>> Signed-off-by: Kyungmin Park <[email protected]>
>> ---
>> ?arch/arm/plat-samsung/include/plat/gpio-core.h | ? ?6 ++++++
>> ?1 files changed, 6 insertions(+), 0 deletions(-)
>>
>> diff --git a/arch/arm/plat-samsung/include/plat/gpio-core.h
> b/arch/arm/plat-
>> samsung/include/plat/gpio-core.h
>> index e358c7d..c8681e0 100644
>> --- a/arch/arm/plat-samsung/include/plat/gpio-core.h
>> +++ b/arch/arm/plat-samsung/include/plat/gpio-core.h
>> @@ -14,6 +14,12 @@
>> ?#define GPIOCON_OFF ?(0x00)
>> ?#define GPIODAT_OFF ?(0x04)
>>
>> +#define S5P_GPIO_LEVEL_LOW ? ? ? ? ? (0x00)
>> +#define S5P_GPIO_LEVEL_HIGH ? ? ? ? ?(0x01)
>> +#define S5P_GPIO_EDGE_FALLING ? ? ? ? ? ? ? ?(0x02)
>> +#define S5P_GPIO_EDGE_RISING ? ? ? ? (0x03)
>> +#define S5P_GPIO_EDGE_BOTH ? ? ? ? ? (0x04)
>
> Why should we change the name of definition from S5P_EXTINT_XXX?
> If we use that, we don't need to change other files.

External interrupt is one of GPIOs. and it's used for GPIO interrupt.
Do you want to use the EXTINT at generic gpio function?

Also change the name format as IRQ_TYPE_* style.

Thank you,
Kyungmin Park

>
>> +
>> ?#define con_4bit_shift(__off) ((__off) * 4)
>>
>> ?/* Define the core gpiolib support functions that the s3c platforms may
>> --
>
> Thanks.
>
> Best regards,
> Kgene.
> --
> Kukjin Kim <[email protected]>, Senior Engineer,
> SW Solution Development Team, Samsung Electronics Co., Ltd.
>
>

2010-09-01 00:36:32

by Kukjin Kim

Subject: RE: [PATCH 1/3] ARM: Samsung S5P: Move the common Samsung S5P series GPIO level type

Kyungmin Park wrote:
>
> On Mon, Aug 30, 2010 at 9:01 PM, Kukjin Kim <[email protected]> wrote:
> > Kyungmin Park wrote:
> >>
> >> From: Kyungmin Park <[email protected]>
> >>
> >> Samsung S5P series has common level type. It's different from S3C
series.
> >>
> >> Signed-off-by: Kyungmin Park <[email protected]>
> >> ---
> >> ?arch/arm/plat-samsung/include/plat/gpio-core.h | ? ?6 ++++++
> >> ?1 files changed, 6 insertions(+), 0 deletions(-)
> >>
> >> diff --git a/arch/arm/plat-samsung/include/plat/gpio-core.h
> > b/arch/arm/plat-
> >> samsung/include/plat/gpio-core.h
> >> index e358c7d..c8681e0 100644
> >> --- a/arch/arm/plat-samsung/include/plat/gpio-core.h
> >> +++ b/arch/arm/plat-samsung/include/plat/gpio-core.h
> >> @@ -14,6 +14,12 @@
> >> ?#define GPIOCON_OFF ?(0x00)
> >> ?#define GPIODAT_OFF ?(0x04)
> >>
> >> +#define S5P_GPIO_LEVEL_LOW ? ? ? ? ? (0x00)
> >> +#define S5P_GPIO_LEVEL_HIGH ? ? ? ? ?(0x01)
> >> +#define S5P_GPIO_EDGE_FALLING ? ? ? ? ? ? ? ?(0x02)
> >> +#define S5P_GPIO_EDGE_RISING ? ? ? ? (0x03)
> >> +#define S5P_GPIO_EDGE_BOTH ? ? ? ? ? (0x04)
> >
> > Why should we change the name of definition from S5P_EXTINT_XXX?
> > If we use that, we don't need to change other files.
>
> External interrupt is one of GPIOs. and it's used for GPIO interrupt.
> Do you want to use the EXTINT at generic gpio function?
>
Right, it is one of the GPIO pin's usage.
But it doesn't mean that should be used like/with generic GPIO...
Even though the value of their polarity is same.

Anyway,...let's think about that again.

> Also change the name format as IRQ_TYPE_* style.
>
(snip)

Thanks.

Best regards,
Kgene.
--
Kukjin Kim <[email protected]>, Senior Engineer,
SW Solution Development Team, Samsung Electronics Co., Ltd.