2005-09-06 18:32:13

by Alejandro Bonilla

[permalink] [raw]
Subject: IPW2100 Kconfig

Hi,

I checked the IPW2100 in the current git from linux-2.6 and the menuconfig
help (Kconfig) says you need to put the firmware in /etc/firmware, it should
be /lib/firmware.

Who should I send the "patch" to? Or can someone simply change that?

Thanks,

.Alejandro


2005-09-06 18:47:13

by Jesper Juhl

[permalink] [raw]
Subject: [PATCH] wrong firmware location in IPW2100 Kconfig entry (Was: IPW2100 Kconfig)

On Tuesday 06 September 2005 20:32, Alejandro Bonilla wrote:
> Hi,
>
> I checked the IPW2100 in the current git from linux-2.6 and the menuconfig
> help (Kconfig) says you need to put the firmware in /etc/firmware, it should
> be /lib/firmware.
>
> Who should I send the "patch" to? Or can someone simply change that?
>

Firmware should go into /lib/firmware, not /etc/firmware.

Found by Alejandro Bonilla.


Signed-off-by: Jesper Juhl <[email protected]>
---

drivers/net/wireless/Kconfig | 2 +-
1 files changed, 1 insertion(+), 1 deletion(-)

--- linux-2.6.13-mm1-orig/drivers/net/wireless/Kconfig 2005-09-02 23:59:51.000000000 +0200
+++ linux-2.6.13-mm1/drivers/net/wireless/Kconfig 2005-09-06 20:39:45.000000000 +0200
@@ -152,7 +152,7 @@
In order to use this driver, you will need a firmware image for it.
You can obtain the firmware from
<http://ipw2100.sf.net/>. Once you have the firmware image, you
- will need to place it in /etc/firmware.
+ will need to place it in /lib/firmware.

You will also very likely need the Wireless Tools in order to
configure your card:


2005-09-06 18:51:35

by Alejandro Bonilla

[permalink] [raw]
Subject: RE: [PATCH] wrong firmware location in IPW2100 Kconfig entry (Was: IPW2100 Kconfig)

> > Who should I send the "patch" to? Or can someone simply change that?

Jesper,

Thanks. I also had a question. To whom is this patch sent to? Netdev or LK?
How does one determine?

.Alejandro

>
> Firmware should go into /lib/firmware, not /etc/firmware.
>
> Found by Alejandro Bonilla.
>
>
> Signed-off-by: Jesper Juhl <[email protected]>

2005-09-07 12:45:08

by Jiri Slaby

[permalink] [raw]
Subject: Re: [PATCH] wrong firmware location in IPW2100 Kconfig entry (Was: IPW2100 Kconfig)

Alejandro Bonilla napsal(a):

> Thanks. I also had a question. To whom is this patch sent to? Netdev or LK?
>How does one determine?
>
>
Read, read, read. Documentation/SubmittingPatches, point 4.

--
Jiri Slaby http://www.fi.muni.cz/~xslaby
~\-/~ [email protected] ~\-/~
241B347EC88228DE51EE A49C4A73A25004CB2A10

2005-09-08 20:27:10

by Pavel Machek

[permalink] [raw]
Subject: Re: IPW2100 Kconfig

Hi!

> I checked the IPW2100 in the current git from linux-2.6 and the menuconfig
> help (Kconfig) says you need to put the firmware in /etc/firmware, it should
> be /lib/firmware.
>
> Who should I send the "patch" to? Or can someone simply change that?

Are you sure it is not distro-dependend?
--
64 bytes from 195.113.31.123: icmp_seq=28 ttl=51 time=448769.1 ms

2005-09-08 21:11:44

by Bharath Ramesh

[permalink] [raw]
Subject: Re: IPW2100 Kconfig

AFAIK hotplug looks for firmware in /lib/firmware and not /etc/firmware.

On 9/8/05, Pavel Machek <[email protected]> wrote:
> Hi!
>
> > I checked the IPW2100 in the current git from linux-2.6 and the menuconfig
> > help (Kconfig) says you need to put the firmware in /etc/firmware, it should
> > be /lib/firmware.
> >
> > Who should I send the "patch" to? Or can someone simply change that?
>
> Are you sure it is not distro-dependend?
> --
> 64 bytes from 195.113.31.123: icmp_seq=28 ttl=51 time=448769.1 ms
>
> -
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to [email protected]
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
>

2005-09-08 21:17:50

by Alejandro Bonilla

[permalink] [raw]
Subject: RE: IPW2100 Kconfig


> AFAIK hotplug looks for firmware in /lib/firmware and not
> /etc/firmware.
>
> On 9/8/05, Pavel Machek <[email protected]> wrote:
> > Hi!
> >
> > > I checked the IPW2100 in the current git from
> linux-2.6 and the menuconfig
> > > help (Kconfig) says you need to put the firmware in
> /etc/firmware, it should
> > > be /lib/firmware.
> > >
> > > Who should I send the "patch" to? Or can someone simply
> change that?
> >
> > Are you sure it is not distro-dependend?
> > --

Right, IPW2100 came with Legacy fw load first. Maybe that was dragged from
long time ago and used incorrectly.

I'm 100% sure that new versions of hotplug try to look at /lib/firmware and
was /usr/lib/hotplug/firmware before, but there was some discussion that
/lib would make more sense cause /usr could be dependant on other stuff.

Jesper already signed the patch.

.Alejandro