This patch marks userspace header export for unicore32 as broken so that
it is skipped when running make headers_install_all.
Signed-off-by: Peter Foley <[email protected]>
---
scripts/headers.sh | 2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/scripts/headers.sh b/scripts/headers.sh
index 978b42b..3ae218e 100755
--- a/scripts/headers.sh
+++ b/scripts/headers.sh
@@ -21,6 +21,8 @@ for arch in ${archs}; do
;;
cris) # headers export are known broken
;;
+ unicore32) # broken
+ ;;
*)
if [ -d ${srctree}/arch/${arch} ]; then
do_command $1 ${arch}
--
1.7.5.rc1
Hi,
On Sun, Apr 24, 2011 at 7:15 PM, Peter Foley <[email protected]> wrote:
> This patch marks userspace header export for unicore32 as broken so that
> it is skipped when running make headers_install_all.
>
Why ?
I would expect you to send this to arch/unicore32 maintainer too, he
is not in the CC: list.
- Arnaud
> Signed-off-by: Peter Foley <[email protected]>
> ---
> ?scripts/headers.sh | ? ?2 ++
> ?1 files changed, 2 insertions(+), 0 deletions(-)
>
> diff --git a/scripts/headers.sh b/scripts/headers.sh
> index 978b42b..3ae218e 100755
> --- a/scripts/headers.sh
> +++ b/scripts/headers.sh
> @@ -21,6 +21,8 @@ for arch in ${archs}; do
> ? ? ? ? ? ? ? ?;;
> ? ? ? ?cris) ? ? ?# headers export are known broken
> ? ? ? ? ? ? ? ?;;
> + ? ? ? unicore32) # broken
> + ? ? ? ? ? ? ? ;;
> ? ? ? ?*)
> ? ? ? ? ? ? ? ?if [ -d ${srctree}/arch/${arch} ]; then
> ? ? ? ? ? ? ? ? ? ? ? ?do_command $1 ${arch}
> --
> 1.7.5.rc1
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kbuild" in
> the body of a message to [email protected]
> More majordomo info at ?http://vger.kernel.org/majordomo-info.html
>
On Tue, Apr 26, 2011 at 2:48 PM, Arnaud Lacombe <[email protected]> wrote:
> Hi,
>
> On Sun, Apr 24, 2011 at 7:15 PM, Peter Foley <[email protected]> wrote:
>> This patch marks userspace header export for unicore32 as broken so that
>> it is skipped when running make headers_install_all.
>>
> Why ?
>
> I would expect you to send this to arch/unicore32 maintainer too, he
> is not in the CC: list.
+1
If you see errors when install kernel headers on unicore32, fix them instead
of marking it as broken.
On 4/26/2011 2:48 AM, Arnaud Lacombe wrote:
> Hi,
>
> On Sun, Apr 24, 2011 at 7:15 PM, Peter Foley <[email protected]> wrote:
>> This patch marks userspace header export for unicore32 as broken so that
>> it is skipped when running make headers_install_all.
>>
> Why ?
>
> I would expect you to send this to arch/unicore32 maintainer too, he
> is not in the CC: list.
>
> - Arnaud
>
Sorry, I've CC'd him on this email.
The error I currently get is:
INSTALL include (0 file)
make[3]: *** No rule to make target `/usr/src/git/arch/unicore32/include/asm/auxvec.h', needed by `/root/linux/t/usr/include/asm/.install'. Stop.
make[2]: *** [headers_install] Error 2
make[1]: *** [sub-make] Error 2
make: *** [all] Error 2
Patch below.
This patch marks userspace header export for unicore32 as broken so that
it is skipped when running make headers_install_all.
Signed-off-by: Peter Foley <[email protected]>
---
scripts/headers.sh | 2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/scripts/headers.sh b/scripts/headers.sh
index 978b42b..3ae218e 100755
--- a/scripts/headers.sh
+++ b/scripts/headers.sh
@@ -21,6 +21,8 @@ for arch in ${archs}; do
;;
cris) # headers export are known broken
;;
+ unicore32) # broken
+ ;;
*)
if [ -d ${srctree}/arch/${arch} ]; then
do_command $1 ${arch}
-- 1.7.5.rc1
On 4/26/2011 1:07 PM, Am?rico Wang wrote:
> On Tue, Apr 26, 2011 at 2:48 PM, Arnaud Lacombe <[email protected]> wrote:
>> Hi,
>>
>> On Sun, Apr 24, 2011 at 7:15 PM, Peter Foley <[email protected]> wrote:
>>> This patch marks userspace header export for unicore32 as broken so that
>>> it is skipped when running make headers_install_all.
>>>
>> Why ?
>>
>> I would expect you to send this to arch/unicore32 maintainer too, he
>> is not in the CC: list.
>
> +1
>
> If you see errors when install kernel headers on unicore32, fix them instead
> of marking it as broken.
The problem with unicore32 is that it generates various stub headers at compile time in include/generated/asm.
I believe the unicore32 maintainer is already aware of headers_install not working (see https://lkml.org/lkml/2011/1/8/11).
I'm adding him to the CC list on this email.
> -----Original Message-----
> From: Peter Foley [mailto:[email protected]]
> Sent: Wednesday, April 27, 2011 5:04 AM
> To: Am?rico Wang
> Cc: Arnaud Lacombe; [email protected]; [email protected]; [email protected]; [email protected]
> Subject: Re: [PATCH] kbuild: mark unicore32 header export as broken
>
> On 4/26/2011 1:07 PM, Am?rico Wang wrote:
> > On Tue, Apr 26, 2011 at 2:48 PM, Arnaud Lacombe <[email protected]> wrote:
> >> Hi,
> >>
> >> On Sun, Apr 24, 2011 at 7:15 PM, Peter Foley <[email protected]> wrote:
> >>> This patch marks userspace header export for unicore32 as broken so that
> >>> it is skipped when running make headers_install_all.
> >>>
> >> Why ?
> >>
> >> I would expect you to send this to arch/unicore32 maintainer too, he
> >> is not in the CC: list.
> >
> > +1
> >
> > If you see errors when install kernel headers on unicore32, fix them instead
> > of marking it as broken.
>
> The problem with unicore32 is that it generates various stub headers at compile time in include/generated/asm.
> I believe the unicore32 maintainer is already aware of headers_install not working (see https://lkml.org/lkml/2011/1/8/11).
Yes, thanks.
I am waiting for the generic-y patch by Sam. (also CC to Sam)
Sorry to broke the rule of headers_install_all.
Thanks Peter. The patch not applied since I do need headers_install.
Thanks & Regards,
Guan Xuetao