2015-08-11 18:33:51

by Jaegeuk Kim

Subject: [PATCH] f2fs: do not assing a new segment for dio under space shortage

If there is not enough free segment, we should not assign a new segment
explicitly. Otherwise, we can run out of free segment.

Signed-off-by: Jaegeuk Kim <[email protected]>
---
fs/f2fs/segment.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/fs/f2fs/segment.c b/fs/f2fs/segment.c
index 7d53cb4..bf1605d 100644
--- a/fs/f2fs/segment.c
+++ b/fs/f2fs/segment.c
@@ -1225,7 +1225,8 @@ void allocate_data_block(struct f2fs_sb_info *sbi, struct page *page,
mutex_lock(&sit_i->sentry_lock);

/* direct_io'ed data is aligned to the segment for better performance */
- if (direct_io && curseg->next_blkoff)
+ if (direct_io && curseg->next_blkoff &&
+ !has_not_enough_free_secs(sbi, 0))
__allocate_new_segments(sbi, type);

*new_blkaddr = NEXT_FREE_BLKADDR(sbi, curseg);
--
2.1.1

2015-08-12 09:45:23

by Chao Yu

Subject: RE: [f2fs-dev] [PATCH] f2fs: do not assing a new segment for dio under space shortage

> -----Original Message-----
> From: Jaegeuk Kim [mailto:[email protected]]
> Sent: Wednesday, August 12, 2015 2:34 AM
> To: [email protected]; [email protected];
> [email protected]
> Cc: Jaegeuk Kim
> Subject: [f2fs-dev] [PATCH] f2fs: do not assing a new segment for dio under space shortage
>
> If there is not enough free segment, we should not assign a new segment
> explicitly. Otherwise, we can run out of free segment.
>
> Signed-off-by: Jaegeuk Kim <[email protected]>

Reviewed-by: Chao Yu <[email protected]>