2023-10-13 17:27:56

by Jakub Kicinski

Subject: [PATCH] checkpatch: avoid warning about Possible repeated word: 'Google'

syzbot stack traces often come with the following line:

Hardware name: Google Google Compute Engine/Google Compute Engine...

This generates the repeated word warning from checkpatch.
It hit 49 times in the last 6 months in networking
(false-positive rate of 0.34%). Mute the warning for "Google",
there's no other word which comes close to being this clear
cut false-positive in our traffic.

Signed-off-by: Jakub Kicinski <[email protected]>
---
CC: [email protected]
CC: [email protected]
CC: [email protected]
CC: [email protected]
---
scripts/checkpatch.pl | 2 ++
1 file changed, 2 insertions(+)

diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
index 7d16f863edf1..c99f8f93cb4c 100755
--- a/scripts/checkpatch.pl
+++ b/scripts/checkpatch.pl
@@ -3524,6 +3524,8 @@ sub process {

next if (lc($first) ne lc($second));
next if ($first eq 'long');
+ # syzbot reports contain "Hardware name: Google Google Compute Engine"
+ next if ($first eq 'Google');

# check for character before and after the word matches
my $start_char = '';
--
2.41.0

2023-10-13 18:11:55

by Joe Perches

Subject: Re: [PATCH] checkpatch: avoid warning about Possible repeated word: 'Google'

On Fri, 2023-10-13 at 10:27 -0700, Jakub Kicinski wrote:
> syzbot stack traces often come with the following line:
>
> Hardware name: Google Google Compute Engine/Google Compute Engine...

If you must, you must, but I wonder if code to ignore
syzbot blocks might be more sensible. I don't see
obvious syzbot start/end block markers though.


> This generates the repeated word warning from checkpatch.
> It hit 49 times in the last 6 months in networking
> (false-positive rate of 0.34%). Mute the warning for "Google",
> there's no other word which comes close to being this clear
> cut false-positive in our traffic.
>
> Signed-off-by: Jakub Kicinski <[email protected]>
> ---
> CC: [email protected]
> CC: [email protected]
> CC: [email protected]
> CC: [email protected]
> ---
> scripts/checkpatch.pl | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
> index 7d16f863edf1..c99f8f93cb4c 100755
> --- a/scripts/checkpatch.pl
> +++ b/scripts/checkpatch.pl
> @@ -3524,6 +3524,8 @@ sub process {
>
> next if (lc($first) ne lc($second));
> next if ($first eq 'long');
> + # syzbot reports contain "Hardware name: Google Google Compute Engine"
> + next if ($first eq 'Google');
>
> # check for character before and after the word matches
> my $start_char = '';