2012-10-17 14:16:39

by Laurent Pinchart

Subject: [PATCH] drivers: cma: Fix wrong CMA selected region size default value

Kconfig lists CMA_SIZE_SEL_ABSOLUTE as the default value fo the CMA
selected region size, but that option isn't available in the defined
choices. Set the default to CMA_SIZE_SEL_MBYTES instead.

Signed-off-by: Laurent Pinchart <[email protected]>
---
drivers/base/Kconfig | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/base/Kconfig b/drivers/base/Kconfig
index 08b4c52..b34b5cd 100644
--- a/drivers/base/Kconfig
+++ b/drivers/base/Kconfig
@@ -236,7 +236,7 @@ config CMA_SIZE_PERCENTAGE

choice
prompt "Selected region size"
- default CMA_SIZE_SEL_ABSOLUTE
+ default CMA_SIZE_SEL_MBYTES

config CMA_SIZE_SEL_MBYTES
bool "Use mega bytes value only"
--
Regards,

Laurent Pinchart

2012-10-18 13:14:23

by Marek Szyprowski

Subject: RE: [PATCH] drivers: cma: Fix wrong CMA selected region size default value

Hi Laurent,

On Wednesday, October 17, 2012 4:17 PM Laurent Pinchart wrote:

> Kconfig lists CMA_SIZE_SEL_ABSOLUTE as the default value fo the CMA
> selected region size, but that option isn't available in the defined
> choices. Set the default to CMA_SIZE_SEL_MBYTES instead.
>
> Signed-off-by: Laurent Pinchart <[email protected]>
> ---
> drivers/base/Kconfig | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/base/Kconfig b/drivers/base/Kconfig
> index 08b4c52..b34b5cd 100644
> --- a/drivers/base/Kconfig
> +++ b/drivers/base/Kconfig
> @@ -236,7 +236,7 @@ config CMA_SIZE_PERCENTAGE
>
> choice
> prompt "Selected region size"
> - default CMA_SIZE_SEL_ABSOLUTE
> + default CMA_SIZE_SEL_MBYTES
>
> config CMA_SIZE_SEL_MBYTES
> bool "Use mega bytes value only"
> --

Right, thanks for the fix, applied to my dma-mapping tree.

Best regards
--
Marek Szyprowski
Samsung Poland R&D Center