2014-10-06 15:47:25

by Sylwester Nawrocki

[permalink] [raw]
Subject: [PATCH] usb: Remove references to non-existent PLAT_S5P symbol

The PLAT_S5P Kconfig symbol was removed in commit d78c16ccde96
("ARM: SAMSUNG: Remove remaining legacy code"). There are still
some references left, fix that by replacing them with ARCH_S5PV210.

Reported-by: Paul Bolle <[email protected]>
Signed-off-by: Sylwester Nawrocki <[email protected]>
---
drivers/usb/host/Kconfig | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/usb/host/Kconfig b/drivers/usb/host/Kconfig
index 82800a7..6f1d48e 100644
--- a/drivers/usb/host/Kconfig
+++ b/drivers/usb/host/Kconfig
@@ -220,7 +220,7 @@ config USB_EHCI_SH

config USB_EHCI_EXYNOS
tristate "EHCI support for Samsung S5P/EXYNOS SoC Series"
- depends on PLAT_S5P || ARCH_EXYNOS
+ depends on ARCH_S5PV210 || ARCH_EXYNOS
help
Enable support for the Samsung Exynos SOC's on-chip EHCI controller.

@@ -527,7 +527,7 @@ config USB_OHCI_SH

config USB_OHCI_EXYNOS
tristate "OHCI support for Samsung S5P/EXYNOS SoC Series"
- depends on PLAT_S5P || ARCH_EXYNOS
+ depends on ARCH_S5PV210 || ARCH_EXYNOS
help
Enable support for the Samsung Exynos SOC's on-chip OHCI controller.

--
1.7.9.5


2014-10-06 16:38:38

by Paul Bolle

[permalink] [raw]
Subject: Re: [PATCH] usb: Remove references to non-existent PLAT_S5P symbol

On Mon, 2014-10-06 at 17:47 +0200, Sylwester Nawrocki wrote:
> The PLAT_S5P Kconfig symbol was removed in commit d78c16ccde96
> ("ARM: SAMSUNG: Remove remaining legacy code"). There are still
> some references left, fix that by replacing them with ARCH_S5PV210.
>
> Reported-by: Paul Bolle <[email protected]>
> Signed-off-by: Sylwester Nawrocki <[email protected]>

As with the "[media]" patch: should
Fixes: d78c16ccde96 ("ARM: SAMSUNG: Remove remaining legacy code")

be added so this will end up in stable for v3.17?

> drivers/usb/host/Kconfig | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/usb/host/Kconfig b/drivers/usb/host/Kconfig
> index 82800a7..6f1d48e 100644
> --- a/drivers/usb/host/Kconfig
> +++ b/drivers/usb/host/Kconfig
> @@ -220,7 +220,7 @@ config USB_EHCI_SH
>
> config USB_EHCI_EXYNOS
> tristate "EHCI support for Samsung S5P/EXYNOS SoC Series"
> - depends on PLAT_S5P || ARCH_EXYNOS
> + depends on ARCH_S5PV210 || ARCH_EXYNOS
> help
> Enable support for the Samsung Exynos SOC's on-chip EHCI controller.
>
> @@ -527,7 +527,7 @@ config USB_OHCI_SH
>
> config USB_OHCI_EXYNOS
> tristate "OHCI support for Samsung S5P/EXYNOS SoC Series"
> - depends on PLAT_S5P || ARCH_EXYNOS
> + depends on ARCH_S5PV210 || ARCH_EXYNOS
> help
> Enable support for the Samsung Exynos SOC's on-chip OHCI controller.
>

Thanks again!


Paul Bolle

2014-10-07 00:46:10

by Jingoo Han

[permalink] [raw]
Subject: Re: [PATCH] usb: Remove references to non-existent PLAT_S5P symbol

On Tuesday, October 07, 2014 12:47 AM, Sylwester Nawrocki wrote:
>
> The PLAT_S5P Kconfig symbol was removed in commit d78c16ccde96
> ("ARM: SAMSUNG: Remove remaining legacy code"). There are still
> some references left, fix that by replacing them with ARCH_S5PV210.
>
> Reported-by: Paul Bolle <[email protected]>
> Signed-off-by: Sylwester Nawrocki <[email protected]>

Acked-by: Jingoo Han <[email protected]>

Best regards,
Jingoo Han

> ---
> drivers/usb/host/Kconfig | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/usb/host/Kconfig b/drivers/usb/host/Kconfig
> index 82800a7..6f1d48e 100644
> --- a/drivers/usb/host/Kconfig
> +++ b/drivers/usb/host/Kconfig
> @@ -220,7 +220,7 @@ config USB_EHCI_SH
>
> config USB_EHCI_EXYNOS
> tristate "EHCI support for Samsung S5P/EXYNOS SoC Series"
> - depends on PLAT_S5P || ARCH_EXYNOS
> + depends on ARCH_S5PV210 || ARCH_EXYNOS
> help
> Enable support for the Samsung Exynos SOC's on-chip EHCI controller.
>
> @@ -527,7 +527,7 @@ config USB_OHCI_SH
>
> config USB_OHCI_EXYNOS
> tristate "OHCI support for Samsung S5P/EXYNOS SoC Series"
> - depends on PLAT_S5P || ARCH_EXYNOS
> + depends on ARCH_S5PV210 || ARCH_EXYNOS
> help
> Enable support for the Samsung Exynos SOC's on-chip OHCI controller.
>
> --
> 1.7.9.5