2011-03-19 15:54:32

by Chris Metcalf

[permalink] [raw]
Subject: [PATCH] asm-generic: support clock_adjtime() in <asm-generic/unistd.h>

A syscall was added without being added to asm-generic, which
makes tile (and presumably score and unicore32) break.

Signed-off-by: Chris Metcalf <[email protected]>
Cc: Arnd Bergmann <[email protected]>
Cc: Guan Xuetao <[email protected]>
Cc: Chen Liqin <[email protected]>
Cc: Lennox Wu <[email protected]>
---
include/asm-generic/unistd.h | 4 +++-
1 files changed, 3 insertions(+), 1 deletions(-)

diff --git a/include/asm-generic/unistd.h b/include/asm-generic/unistd.h
index 57af033..d94f447 100644
--- a/include/asm-generic/unistd.h
+++ b/include/asm-generic/unistd.h
@@ -650,9 +650,11 @@ __SYSCALL(__NR_fanotify_mark, sys_fanotify_mark)
__SYSCALL(__NR_name_to_handle_at, sys_name_to_handle_at)
#define __NR_open_by_handle_at 265
__SYSCALL(__NR_open_by_handle_at, sys_open_by_handle_at)
+#define __NR_clock_adjtime 266
+__SYSCALL(__NR_clock_adjtime, sys_clock_adjtime)

#undef __NR_syscalls
-#define __NR_syscalls 266
+#define __NR_syscalls 267

/*
* All syscalls below here should go away really,
--
1.6.5.2


2011-03-19 20:47:27

by Arnd Bergmann

[permalink] [raw]
Subject: Re: [PATCH] asm-generic: support clock_adjtime() in <asm-generic/unistd.h>

On Saturday 19 March 2011 16:47:53 Chris Metcalf wrote:
>
> A syscall was added without being added to asm-generic, which
> makes tile (and presumably score and unicore32) break.
>
> Signed-off-by: Chris Metcalf <[email protected]>
> Cc: Arnd Bergmann <[email protected]>
> Cc: Guan Xuetao <[email protected]>
> Cc: Chen Liqin <[email protected]>
> Cc: Lennox Wu <[email protected]>

I don't consider it actually broken, but your patch
is definitely needed to support the new syscall, and
looks totally correct.

Acked-by: Arnd Bergmann <[email protected]>

I don't have any other changes queued up for asm-generic
in this release, so please just merge it through your
tree if you like.

Arnd

2011-03-22 12:33:08

by Xuetao Guan

[permalink] [raw]
Subject: RE: [PATCH] asm-generic: support clock_adjtime() in <asm-generic/unistd.h>



> -----Original Message-----
> From: Arnd Bergmann [mailto:[email protected]]
> Sent: Sunday, March 20, 2011 4:47 AM
> To: Chris Metcalf
> Cc: [email protected]; Guan Xuetao; Chen Liqin; Lennox Wu
> Subject: Re: [PATCH] asm-generic: support clock_adjtime() in <asm-generic/unistd.h>
>
> On Saturday 19 March 2011 16:47:53 Chris Metcalf wrote:
> >
> > A syscall was added without being added to asm-generic, which
> > makes tile (and presumably score and unicore32) break.
> >
> > Signed-off-by: Chris Metcalf <[email protected]>
> > Cc: Arnd Bergmann <[email protected]>
> > Cc: Guan Xuetao <[email protected]>
> > Cc: Chen Liqin <[email protected]>
> > Cc: Lennox Wu <[email protected]>
>
> I don't consider it actually broken, but your patch
> is definitely needed to support the new syscall, and
> looks totally correct.
>
> Acked-by: Arnd Bergmann <[email protected]>
>
> I don't have any other changes queued up for asm-generic
> in this release, so please just merge it through your
> tree if you like.
>
> Arnd

Looks good. At least it will remove the warning for unimplemented syscall.

Thanks & Regards.

Guan Xuetao