2022-08-01 03:25:32

by Kiwoong Kim

Subject: [RESEND PATCH v1] scsi: ufs: enable link lost interrupt

Link lost is treated as fatal error with the following
patch, but its event isn't registered as interrupt source,
so I enable it.
--
scsi: ufs: Treat link loss as fatal error

Signed-off-by: Kiwoong Kim <[email protected]>
---
drivers/scsi/ufs/ufshci.h | 6 +-----
1 file changed, 1 insertion(+), 5 deletions(-)

diff --git a/drivers/scsi/ufs/ufshci.h b/drivers/scsi/ufs/ufshci.h
index a7ff0e5..0b627f4 100644
--- a/drivers/scsi/ufs/ufshci.h
+++ b/drivers/scsi/ufs/ufshci.h
@@ -133,11 +133,7 @@ static inline u32 ufshci_version(u32 major, u32 minor)

#define UFSHCD_UIC_MASK (UIC_COMMAND_COMPL | UFSHCD_UIC_PWR_MASK)

-#define UFSHCD_ERROR_MASK (UIC_ERROR |\
- DEVICE_FATAL_ERROR |\
- CONTROLLER_FATAL_ERROR |\
- SYSTEM_BUS_FATAL_ERROR |\
- CRYPTO_ENGINE_FATAL_ERROR)
+#define UFSHCD_ERROR_MASK (UIC_ERROR | INT_FATAL_ERRORS)

#define INT_FATAL_ERRORS (DEVICE_FATAL_ERROR |\
CONTROLLER_FATAL_ERROR |\
--
2.7.4

2022-08-01 17:25:34

by Bart Van Assche

Subject: Re: [RESEND PATCH v1] scsi: ufs: enable link lost interrupt

On 7/31/22 20:09, Kiwoong Kim wrote:
> Link lost is treated as fatal error with the following
> patch, but its event isn't registered as interrupt source,
> so I enable it.
> --
> scsi: ufs: Treat link loss as fatal error

Is this patch perhaps intended as a fix for patch "scsi: ufs: Treat link
loss as fatal error"? If so, does it need a Fixes: tag?

Thanks,

Bart.

2022-08-02 01:47:31

by Kiwoong Kim

Subject: RE: [RESEND PATCH v1] scsi: ufs: enable link lost interrupt

> > Link lost is treated as fatal error with the following patch, but its
> > event isn't registered as interrupt source, so I enable it.
> > --
> > scsi: ufs: Treat link loss as fatal error
>
> Is this patch perhaps intended as a fix for patch "scsi: ufs: Treat link
> loss as fatal error"? If so, does it need a Fixes: tag?
>
> Thanks,
>
> Bart.

Right and let me add the tag.

Thanks.
Kiwoong Kim