The KConfig file for VME_USER ('drivers/staging/vme/devices/Kconfig')
sourced at "drivers/vme/boards/KConfig" misses a `depends on` line for
VME_BUS, which is unnoticeable for menuconfig users who aren't be able
to select it through this interface without setting the CONFIG_VME_BUS
option because it's nested on VME_BUS menu entry.
A patch to move appropriately this driver to the "Staging" submenu
([PATCH 1/3], originally sent as a single patch submitted at
https://lore.kernel.org/linux-staging/[email protected]/T/#t),
however, unveiled this missing `depends on` line, since it moved the
`source` line for VME_USER's KConfig to somewhere else, allowing it to
be compiled without the support for VME_BUS. While it compiles fine and
seems to initialize the driver fine (tested both as module and as built-
in), it seems to make no sense having VME_USER without VME_BUS.
This patches addresses it by adding the VME_BUS to the `depends on` line
at "drivers/staging/vme/devices/Kconfig".
Signed-off-by: Bruno Moreira-Guedes <[email protected]>
---
drivers/staging/vme/devices/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/vme/devices/Kconfig b/drivers/staging/vme/devices/Kconfig
index 5651bb16b28b..e8b4461bf27f 100644
--- a/drivers/staging/vme/devices/Kconfig
+++ b/drivers/staging/vme/devices/Kconfig
@@ -3,7 +3,7 @@ comment "VME Device Drivers"
config VME_USER
tristate "VME user space access driver"
- depends on STAGING
+ depends on STAGING && VME_BUS
help
If you say Y here you want to be able to access a limited number of
VME windows in a manner at least semi-compatible with the interface
--
2.35.3
Please, disregard the following message as there's a typo in the prefix.
On Mon, Apr 18, 2022 at 08:31:09PM -0300, Bruno Moreira-Guedes wrote:
> The KConfig file for VME_USER ('drivers/staging/vme/devices/Kconfig')
> sourced at "drivers/vme/boards/KConfig" misses a `depends on` line for
> VME_BUS, which is unnoticeable for menuconfig users who aren't be able
> to select it through this interface without setting the CONFIG_VME_BUS
> option because it's nested on VME_BUS menu entry.
...
> VME windows in a manner at least semi-compatible with the interface
> --
> 2.35.3
>
It's already sent a new copy with the proper version number. Nothing's
changed except for the message ID and the v2 typo.
On Wed, Apr 20, 2022 at 06:12:58PM -0300, Bruno Moreira-Guedes wrote:
> On Wed, Apr 20, 2022 at 06:43:12PM +0200, Greg Kroah-Hartman wrote:
> > On Mon, Apr 18, 2022 at 08:39:29PM -0300, Bruno Moreira-Guedes wrote:
> > > Please, disregard the following message as there's a typo in the prefix.
> > >
> > > On Mon, Apr 18, 2022 at 08:31:09PM -0300, Bruno Moreira-Guedes wrote:
> > > > The KConfig file for VME_USER ('drivers/staging/vme/devices/Kconfig')
> > > > sourced at "drivers/vme/boards/KConfig" misses a `depends on` line for
> > > > VME_BUS, which is unnoticeable for menuconfig users who aren't be able
> > > > to select it through this interface without setting the CONFIG_VME_BUS
> > > > option because it's nested on VME_BUS menu entry.
> > > ...
> > > > VME windows in a manner at least semi-compatible with the interface
> > > > --
> > > > 2.35.3
> > > >
> > >
> > > It's already sent a new copy with the proper version number. Nothing's
> > > changed except for the message ID and the v2 typo.
> >
> > I can't handle 2 v2 of this same commit, our tools get very confused (as
> > do people.) Would you be able to unwind this if you were in my
> > position?
> I really apologize for this confusion, I really did some mistakes on my
> local branch and had to edit the patches manually to reapply them. While
> working on that I accidentally missed to change the 'v2' to 'v3'. My
> mistake.
>
> Though, there's no 2 v2s, the new one I sent is a v3 as is the rest of
> this thread. So, would it be necessary to unwind anything anyway?
Yes, as I don't see a v3 here. All I see is a mess of commits in a
thread and not a way to easily determine which ones to, and not to,
apply/ignore.
Make it blindingly obvious for me (and everyone else) which is your
latest patch series and which to apply/review.
Remember, some of us get thousands of emails a day to deal with, and
right now I have over 2000 in my review queue to get through. Making my
life simpler is the best thing if you want your patch to be accepted.
thanks,
greg k-h
On Wed, Apr 20, 2022 at 06:43:12PM +0200, Greg Kroah-Hartman wrote:
> On Mon, Apr 18, 2022 at 08:39:29PM -0300, Bruno Moreira-Guedes wrote:
> > Please, disregard the following message as there's a typo in the prefix.
> >
> > On Mon, Apr 18, 2022 at 08:31:09PM -0300, Bruno Moreira-Guedes wrote:
> > > The KConfig file for VME_USER ('drivers/staging/vme/devices/Kconfig')
> > > sourced at "drivers/vme/boards/KConfig" misses a `depends on` line for
> > > VME_BUS, which is unnoticeable for menuconfig users who aren't be able
> > > to select it through this interface without setting the CONFIG_VME_BUS
> > > option because it's nested on VME_BUS menu entry.
> > ...
> > > VME windows in a manner at least semi-compatible with the interface
> > > --
> > > 2.35.3
> > >
> >
> > It's already sent a new copy with the proper version number. Nothing's
> > changed except for the message ID and the v2 typo.
>
> I can't handle 2 v2 of this same commit, our tools get very confused (as
> do people.) Would you be able to unwind this if you were in my
> position?
I really apologize for this confusion, I really did some mistakes on my
local branch and had to edit the patches manually to reapply them. While
working on that I accidentally missed to change the 'v2' to 'v3'. My
mistake.
Though, there's no 2 v2s, the new one I sent is a v3 as is the rest of
this thread. So, would it be necessary to unwind anything anyway?
If this question happens to beb a bad one, my apologies again, I'll soon
do some effort to learn more about how things work from a maintainer's
perspective so next time I make a mistake I'll be able to take the best
curse of action straight away.
>
> Please resubmit a v3 of this series with everything fixed up.
Did you mean a v4 in this case? Or just post the same patch again?
>
> thanks,
>
> greg k-h
On Mon, Apr 18, 2022 at 08:39:29PM -0300, Bruno Moreira-Guedes wrote:
> Please, disregard the following message as there's a typo in the prefix.
>
> On Mon, Apr 18, 2022 at 08:31:09PM -0300, Bruno Moreira-Guedes wrote:
> > The KConfig file for VME_USER ('drivers/staging/vme/devices/Kconfig')
> > sourced at "drivers/vme/boards/KConfig" misses a `depends on` line for
> > VME_BUS, which is unnoticeable for menuconfig users who aren't be able
> > to select it through this interface without setting the CONFIG_VME_BUS
> > option because it's nested on VME_BUS menu entry.
> ...
> > VME windows in a manner at least semi-compatible with the interface
> > --
> > 2.35.3
> >
>
> It's already sent a new copy with the proper version number. Nothing's
> changed except for the message ID and the v2 typo.
I can't handle 2 v2 of this same commit, our tools get very confused (as
do people.) Would you be able to unwind this if you were in my
position?
Please resubmit a v3 of this series with everything fixed up.
thanks,
greg k-h